From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36466)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <roger.pau@citrix.com>) id 1STrE4-0002pR-9W
	for qemu-devel@nongnu.org; Mon, 14 May 2012 05:05:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <roger.pau@citrix.com>) id 1STrDz-0003nl-6v
	for qemu-devel@nongnu.org; Mon, 14 May 2012 05:05:55 -0400
Received: from smtp02.citrix.com ([66.165.176.63]:28314)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <roger.pau@citrix.com>) id 1STrDz-0003nW-1t
	for qemu-devel@nongnu.org; Mon, 14 May 2012 05:05:51 -0400
Message-ID: <4FB0CAE8.7070709@citrix.com>
Date: Mon, 14 May 2012 10:05:44 +0100
From: Roger Pau Monne <roger.pau@citrix.com>
MIME-Version: 1.0
References: <1336738834-27814-1-git-send-email-roger.pau@citrix.com>
	<alpine.LNX.2.00.1205112300170.1508@linmac>
In-Reply-To: <alpine.LNX.2.00.1205112300170.1508@linmac>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH] audio: fix bug in mixeng_template.h build
	on NetBSD
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: malc <av1474@comtv.ru>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

malc escribió:
> On Fri, 11 May 2012, Roger Pau Monne wrote:
>
>> This is a bug fix for rc1, although I think this bug has been present
>> for a long time.
>
> If there's a bug than it's within NetBSD itself, this issue has been
> discussed few times (at least twice it hink) in the past, please search
> the ML archives.
>
> [..snip..]
>

Hello,

I've found

http://copilotco.com/mail-archives/qemu.2008/msg11157.html

and

http://lists.gnu.org/archive/html/qemu-devel/2009-09/msg00255.html

But none of them seems to reach a conclusion about how to solve this. 
The standard regarding stdint.h doesn't forbid having this types defined 
as both typedefs and preprocessor macros, so I don't think this is a 
NetBSD bug. As far as I can see, we have at least three ways of solving 
this:

  - Undef the macros.
  - Use something like concat(conv_natural_, uint8_t, _to_mono) (as done 
on the second thread I've posted).
  - Pass two separate arguments; instead of using:

#define IN_T uint8_t

use something like:

#define BSIZE 8
#define ITYPE uint

But this will probably introduce quite some modifications.

Anyway, how do you think it's best to solve this?

Regards, Roger.