From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59496) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1STtqN-0003AV-QJ for qemu-devel@nongnu.org; Mon, 14 May 2012 07:53:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1STtqJ-0003XO-Vi for qemu-devel@nongnu.org; Mon, 14 May 2012 07:53:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62840) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1STtqJ-0003Wz-Nd for qemu-devel@nongnu.org; Mon, 14 May 2012 07:53:35 -0400 Message-ID: <4FB0F235.1030900@redhat.com> Date: Mon, 14 May 2012 13:53:25 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <4FB0FAC8020000780008369A@nat28.tlf.novell.com> In-Reply-To: <4FB0FAC8020000780008369A@nat28.tlf.novell.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH, v2] qemu/xendisk: properly update stats in ioreq_release() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Beulich Cc: Stefano Stabellini , qemu-devel@nongnu.org, xen-devel Am 14.05.2012 12:30, schrieb Jan Beulich: > While for the "normal" case (called from blk_send_response_all()) > decrementing requests_finished is correct, doing so in the parse error > case is wrong; requests_inflight needs to be decremented instead. > > Change in v2: Adjust coding style. > > Signed-off-by: Jan Beulich I think it would be nicer if a struct ioreq had an explicit state so that you don't have to pass the right state when releasing it. But anyway, the patch looks correct to me: Reviewed-by: Kevin Wolf