From: Kevin Wolf <kwolf@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
aliguori@us.ibm.com, hpoussin@reactos.org,
Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC PATCH 2/2] Split fdd devices off the floppy controller
Date: Mon, 14 May 2012 14:09:00 +0200 [thread overview]
Message-ID: <4FB0F5DC.3020502@redhat.com> (raw)
In-Reply-To: <4FB0F355.5070601@suse.de>
Am 14.05.2012 13:58, schrieb Andreas Färber:
> Am 14.05.2012 10:47, schrieb Kevin Wolf:
>> Am 11.05.2012 17:22, schrieb Markus Armbruster:
>>> For historical reasons, and unlike other block devices, our floppy
>>> devices isa-fdc, sysbus-fdc and SUNW,fdtwo integrate the controller
>>> and the drive(s) in a single qdev. This makes them weird: we need
>>> -global to set up floppy drives, unlike every other optional device.
>>
>> I like the idea of splitting the drives from the controller. In fact, I
>> think we could even try to split them into a separate hw/fdd.c
>
> Seconded, however that might make the patch harder to read due to the
> code movements.
I didn't mean that we should do it in this patch, of course, but as a
second step.
Kevin
next prev parent reply other threads:[~2012-05-14 12:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 15:22 [Qemu-devel] [RFC PATCH 0/2] Split fdd devices off the floppy controller Markus Armbruster
2012-05-11 15:22 ` [Qemu-devel] [RFC PATCH 1/2] Un-inline fdctrl_init_isa() Markus Armbruster
2012-05-14 13:32 ` Anthony Liguori
2012-05-14 13:45 ` Kevin Wolf
2012-05-11 15:22 ` [Qemu-devel] [RFC PATCH 2/2] Split fdd devices off the floppy controller Markus Armbruster
2012-05-14 8:47 ` Kevin Wolf
2012-05-14 8:50 ` Daniel P. Berrange
2012-05-14 11:58 ` Andreas Färber
2012-05-14 12:09 ` Kevin Wolf [this message]
2012-05-16 20:09 ` Markus Armbruster
2012-05-14 13:42 ` Anthony Liguori
2012-05-16 20:30 ` Markus Armbruster
2012-05-24 16:36 ` Markus Armbruster
2012-05-11 15:24 ` [Qemu-devel] [RFC PATCH 0/2] " Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB0F5DC.3020502@redhat.com \
--to=kwolf@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=hpoussin@reactos.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).