From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:55873)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1STu5L-0006lF-RN
	for qemu-devel@nongnu.org; Mon, 14 May 2012 08:09:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1STu5K-000725-0D
	for qemu-devel@nongnu.org; Mon, 14 May 2012 08:09:07 -0400
Received: from mx1.redhat.com ([209.132.183.28]:42417)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1STu5J-00071w-Of
	for qemu-devel@nongnu.org; Mon, 14 May 2012 08:09:05 -0400
Message-ID: <4FB0F5DC.3020502@redhat.com>
Date: Mon, 14 May 2012 14:09:00 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1336749740-18474-1-git-send-email-armbru@redhat.com>
	<1336749740-18474-3-git-send-email-armbru@redhat.com>
	<4FB0C6A7.2040308@redhat.com> <4FB0F355.5070601@suse.de>
In-Reply-To: <4FB0F355.5070601@suse.de>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [RFC PATCH 2/2] Split fdd devices off the floppy
 controller
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>, aliguori@us.ibm.com, hpoussin@reactos.org, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org

Am 14.05.2012 13:58, schrieb Andreas F=E4rber:
> Am 14.05.2012 10:47, schrieb Kevin Wolf:
>> Am 11.05.2012 17:22, schrieb Markus Armbruster:
>>> For historical reasons, and unlike other block devices, our floppy
>>> devices isa-fdc, sysbus-fdc and SUNW,fdtwo integrate the controller
>>> and the drive(s) in a single qdev.  This makes them weird: we need
>>> -global to set up floppy drives, unlike every other optional device.
>>
>> I like the idea of splitting the drives from the controller. In fact, =
I
>> think we could even try to split them into a separate hw/fdd.c
>=20
> Seconded, however that might make the patch harder to read due to the
> code movements.

I didn't mean that we should do it in this patch, of course, but as a
second step.

Kevin