qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <aliguori@us.ibm.com>
To: Amos Kong <akong@redhat.com>
Cc: qemu-devel@nongnu.org, owasserm@redhat.com, jasowang@redhat.com,
	mdroth@linux.vnet.ibm.com, quintela@redhat.com
Subject: Re: [Qemu-devel] [PATCH v12 0/4] support to migrate with IPv6 address
Date: Mon, 14 May 2012 10:04:00 -0500	[thread overview]
Message-ID: <4FB11EE0.2070105@us.ibm.com> (raw)
In-Reply-To: <20120510162606.15504.39510.stgit@t>

On 05/10/2012 11:27 AM, Amos Kong wrote:
> Those patches updated help functions in qemu-socket.c,
> and used them in migrate-tcp.c to supporting IPv6 migration.

Applied all.  Thanks.

I tended to agree with Paolo that lack of IPv6 support is a bug at this point...

Regards,

Anthony Liguori

>
> ---
> Changes from v1:
> - split different changes to small patches, it will be easier to review
> - fixed some problem according to Kevin's comment
>
> Changes from v2:
> - fix issue of returning real error
> - set s->fd to -1 when parse fails, won't call migrate_fd_error()
>
> Changes from v3:
> - try to use help functions in qemu-socket.c
>
> Changes from v4:
> - introduce set_socket_error() to restore real errno
> - fix connect error process
>
> Changes from v5:
> - use error class to pass socket error
>
> Changes from v6:
> - merge error process and nonblock support together
> - fix leak of repeatedly error_set()
> - coding style fix
> - fix EWOULDBLOCK process
>
> Changes from v7:
> - posix: let EWOULDBLOCK fall through to CONNECT_FAILED path
> - add unknown error process
> - fix typo
>
> Changes from v8:
> - reuse rc variable
> - fix a NULL pointer dereference
>
> Changes from v9:
> - handle non-blocking correctly if errp is NULL
>
> Changes from v10:
> - send out the whole series, no change
> - add 'Reviewed-by'
>
> Changes from v11:
> - trivial fix: update error description in qerror.c
>
> ---
>
> Amos Kong (4):
>        qerror: add five qerror strings
>        sockets: change inet_connect() to support nonblock socket
>        sockets: use error class to pass listen error
>        use inet_listen()/inet_connect() to support ipv6 migration
>
>
>   migration-tcp.c |   77 +++++++++++++++----------------------------------------
>   migration.c     |   14 ++++++----
>   migration.h     |    7 +++--
>   nbd.c           |    4 +--
>   qemu-char.c     |    4 +--
>   qemu-sockets.c  |   60 ++++++++++++++++++++++++++++++++++++-------
>   qemu_socket.h   |   10 ++++---
>   qerror.c        |   20 ++++++++++++++
>   qerror.h        |   15 +++++++++++
>   ui/vnc.c        |    5 ++--
>   vl.c            |    7 ++++-
>   11 files changed, 138 insertions(+), 85 deletions(-)
>

      parent reply	other threads:[~2012-05-14 15:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-10 16:27 [Qemu-devel] [PATCH v12 0/4] support to migrate with IPv6 address Amos Kong
2012-05-10 16:28 ` [Qemu-devel] [PATCH v12 1/4] qerror: add five qerror strings Amos Kong
2012-05-10 17:21   ` Michael Roth
2012-05-10 16:28 ` [Qemu-devel] [PATCH v12 2/4] sockets: change inet_connect() to support nonblock socket Amos Kong
2012-05-10 16:28 ` [Qemu-devel] [PATCH v12 3/4] sockets: use error class to pass listen error Amos Kong
2012-05-10 16:28 ` [Qemu-devel] [PATCH v12 4/4] use inet_listen()/inet_connect() to support ipv6 migration Amos Kong
2012-05-10 17:29 ` [Qemu-devel] [PATCH v12 0/4] support to migrate with IPv6 address Eric Blake
2012-05-10 18:12   ` Michael Roth
2012-05-11  6:46     ` Amos Kong
2012-05-11 12:46       ` Eric Blake
2012-05-14 15:04 ` Anthony Liguori [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FB11EE0.2070105@us.ibm.com \
    --to=aliguori@us.ibm.com \
    --cc=akong@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=owasserm@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).