From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50373) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1STwsk-0003Vi-QO for qemu-devel@nongnu.org; Mon, 14 May 2012 11:08:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1STwsf-0001Dm-U0 for qemu-devel@nongnu.org; Mon, 14 May 2012 11:08:18 -0400 Received: from e34.co.us.ibm.com ([32.97.110.152]:49285) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1STwsf-0001Cq-KG for qemu-devel@nongnu.org; Mon, 14 May 2012 11:08:13 -0400 Received: from /spool/local by e34.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 14 May 2012 09:08:07 -0600 Received: from d01relay03.pok.ibm.com (d01relay03.pok.ibm.com [9.56.227.235]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id F0C8AC90072 for ; Mon, 14 May 2012 11:07:10 -0400 (EDT) Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d01relay03.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q4EF79H4081098 for ; Mon, 14 May 2012 11:07:10 -0400 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q4EF6wax019716 for ; Mon, 14 May 2012 09:06:59 -0600 Message-ID: <4FB11EE0.2070105@us.ibm.com> Date: Mon, 14 May 2012 10:04:00 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <20120510162606.15504.39510.stgit@t> In-Reply-To: <20120510162606.15504.39510.stgit@t> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v12 0/4] support to migrate with IPv6 address List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amos Kong Cc: qemu-devel@nongnu.org, owasserm@redhat.com, jasowang@redhat.com, mdroth@linux.vnet.ibm.com, quintela@redhat.com On 05/10/2012 11:27 AM, Amos Kong wrote: > Those patches updated help functions in qemu-socket.c, > and used them in migrate-tcp.c to supporting IPv6 migration. Applied all. Thanks. I tended to agree with Paolo that lack of IPv6 support is a bug at this point... Regards, Anthony Liguori > > --- > Changes from v1: > - split different changes to small patches, it will be easier to review > - fixed some problem according to Kevin's comment > > Changes from v2: > - fix issue of returning real error > - set s->fd to -1 when parse fails, won't call migrate_fd_error() > > Changes from v3: > - try to use help functions in qemu-socket.c > > Changes from v4: > - introduce set_socket_error() to restore real errno > - fix connect error process > > Changes from v5: > - use error class to pass socket error > > Changes from v6: > - merge error process and nonblock support together > - fix leak of repeatedly error_set() > - coding style fix > - fix EWOULDBLOCK process > > Changes from v7: > - posix: let EWOULDBLOCK fall through to CONNECT_FAILED path > - add unknown error process > - fix typo > > Changes from v8: > - reuse rc variable > - fix a NULL pointer dereference > > Changes from v9: > - handle non-blocking correctly if errp is NULL > > Changes from v10: > - send out the whole series, no change > - add 'Reviewed-by' > > Changes from v11: > - trivial fix: update error description in qerror.c > > --- > > Amos Kong (4): > qerror: add five qerror strings > sockets: change inet_connect() to support nonblock socket > sockets: use error class to pass listen error > use inet_listen()/inet_connect() to support ipv6 migration > > > migration-tcp.c | 77 +++++++++++++++---------------------------------------- > migration.c | 14 ++++++---- > migration.h | 7 +++-- > nbd.c | 4 +-- > qemu-char.c | 4 +-- > qemu-sockets.c | 60 ++++++++++++++++++++++++++++++++++++------- > qemu_socket.h | 10 ++++--- > qerror.c | 20 ++++++++++++++ > qerror.h | 15 +++++++++++ > ui/vnc.c | 5 ++-- > vl.c | 7 ++++- > 11 files changed, 138 insertions(+), 85 deletions(-) >