From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52979) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1STxFO-0001Hy-3Y for qemu-devel@nongnu.org; Mon, 14 May 2012 11:31:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1STxFE-00065b-7m for qemu-devel@nongnu.org; Mon, 14 May 2012 11:31:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:65007) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1STxFD-00065M-TM for qemu-devel@nongnu.org; Mon, 14 May 2012 11:31:32 -0400 Message-ID: <4FB12550.7000500@redhat.com> Date: Mon, 14 May 2012 09:31:28 -0600 From: Eric Blake MIME-Version: 1.0 References: <1336763987-10920-1-git-send-email-lcapitulino@redhat.com> <1337007392-30304-1-git-send-email-mdroth@linux.vnet.ibm.com> <1337007392-30304-3-git-send-email-mdroth@linux.vnet.ibm.com> In-Reply-To: <1337007392-30304-3-git-send-email-mdroth@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig8E9EDD04D2659B6A0587AA93" Subject: Re: [Qemu-devel] [PATCH 2/2] qemu-ga: guest-shutdown: become synchronous List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig8E9EDD04D2659B6A0587AA93 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/14/2012 08:56 AM, Michael Roth wrote: > From: Luiz Capitulino >=20 > Last commit dropped qemu-ga's SIGCHLD handler, used to automatically > reap terminated children processes. This introduced a bug to > qmp_guest_shutdown(): it will generate zombies. >=20 > This problem probably doesn't matter in the success case, as the VM > will shutdown anyway, but let's do the right thing and reap the > created process. This ultimately means that guest-shutdown is now a > synchronous command. >=20 > An interesting side effect is that guest-shutdown is now able to > report an error to the client if shutting down fails. >=20 > Signed-off-by: Luiz Capitulino > Signed-off-by: Michael Roth > --- > qga/commands-posix.c | 21 ++++++++++++++++----- > 1 files changed, 16 insertions(+), 5 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig8E9EDD04D2659B6A0587AA93 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJPsSVQAAoJEKeha0olJ0NqTygH/jzXV1/t07kzipExWPGQ4uco LBmGuIb1dSRocPNh5Ftd3NdYLhyRMXCTR4KUH8KhB+Qb7+QZktIFpkSvJYHrzeCT DLWTVue4BQDxDdmUN/RzLdIK8zhzgunxmmzGVZBj99U8cPOL46rNVIHOFQiOEy+K rY5IDlaD6QO4LzhRhQyVF2qCn15pjVfwFnlqFYYO8+3tWcYfR1ghcWVaj+Kwmjos J92dUrLKyFrk56Xl1cAPxXm9UQbZ8iL4JdR+97HwXT5Og1j4/i9FAxJm59+7G45/ kfvjb/Rj+8QFQm8Zmdp9ur12LmV+DYW8YD7lauxuGklv59BJUwfxf7b3PpDR4OE= =meav -----END PGP SIGNATURE----- --------------enig8E9EDD04D2659B6A0587AA93--