From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52653) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SU1Sl-0000md-Q5 for qemu-devel@nongnu.org; Mon, 14 May 2012 16:01:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SU1Sh-0001VA-VW for qemu-devel@nongnu.org; Mon, 14 May 2012 16:01:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11754) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SU1Sh-0001Uj-MS for qemu-devel@nongnu.org; Mon, 14 May 2012 16:01:43 -0400 Message-ID: <4FB16496.7080606@redhat.com> Date: Mon, 14 May 2012 14:01:26 -0600 From: Eric Blake MIME-Version: 1.0 References: <20120514144058.2ffac223@doriath.home> <4FB14611.7090808@redhat.com> <20120514150117.1cc082a5@doriath.home> <20120514150358.6471534d@doriath.home> <4FB151CC.2090007@redhat.com> <20120514165900.27c215a2@doriath.home> In-Reply-To: <20120514165900.27c215a2@doriath.home> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig4787757D805D93EE5EBF06DC" Subject: Re: [Qemu-devel] [PATCH] qemu-ga: guest-shutdown: use only async-signal-safe functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: qemu-devel , mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig4787757D805D93EE5EBF06DC Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/14/2012 01:59 PM, Luiz Capitulino wrote: >>>> I'll declare it then. >>> >>> -Wredundant-decls doesn't like it: >>> >>> /home/lcapitulino/work/src/qmp-unstable/qga/commands-posix.c:38:15: w= arning: redundant redeclaration of =E2=80=98environ=E2=80=99 [-Wredundant= -decls] >>> /usr/include/unistd.h:546:15: note: previous declaration of =E2=80=98= environ=E2=80=99 was here >>> LINK qemu-ga >=20 > What's the worst case if we leave it as is? The build will brake if env= iron > ends up not being declared by some arch, right? In that case we could l= eave it > as is and fix it when it brakes :) Yep, which is precisely why I added my reviewed-by to v2. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig4787757D805D93EE5EBF06DC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEbBAEBCAAGBQJPsWSWAAoJEKeha0olJ0NqtnoH+N+/eI3Xbp3JwxpGT37xd4gX iFwP8k0nCZ6jKszkf8OrpCrSQAF4UOTIqLXptkGsBDsrKmUb2qGu0EOG65CctGpr vRJmXjeU6yHZiUcU8hL3YJtpZ9We6kNM5R0Cz3fOYk+wY+AuWRcrnWvU6P7QdXOz LTiJOyF+I6W/fQI4VXWpnxw5NKqdkGJW145YTaXRVtgpO4v5MokIPSftOy4EXqYB xYf28mSOU3VHaj5zk5+dRkeFXL0PEAfwEXU9aD48/2v3q+sdg7Ne/R4MBAj5MyTt zYK0CDYL227AeTJTnH4Il2GH7026+fqUE5UqdmVlKK8Z/ij2I9DvolnsXlawaw== =VWsP -----END PGP SIGNATURE----- --------------enig4787757D805D93EE5EBF06DC--