From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36402) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SU2MA-0000xp-Ku for qemu-devel@nongnu.org; Mon, 14 May 2012 16:59:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SU2M8-00051I-Qr for qemu-devel@nongnu.org; Mon, 14 May 2012 16:59:02 -0400 Received: from mail-ob0-f173.google.com ([209.85.214.173]:38344) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SU2M8-00051D-MB for qemu-devel@nongnu.org; Mon, 14 May 2012 16:59:00 -0400 Received: by obbwd20 with SMTP id wd20so9724320obb.4 for ; Mon, 14 May 2012 13:58:59 -0700 (PDT) Message-ID: <4FB17210.4030609@codemonkey.ws> Date: Mon, 14 May 2012 15:58:56 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <4FB1672D.7000906@rdsoftware.de> <4FB16B68.3040307@weilnetz.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] Posting a patch? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Stefan Weil , "qemu-devel@nongnu.org" , Erik Rull On 05/14/2012 03:53 PM, Peter Maydell wrote: > On 14 May 2012 21:30, Stefan Weil wrote: >> if you use git for sending, you don't risk that your mailer destroys the >> format of your patch. >> I usually use these commands to send a single patch from the QEMU source >> directory: >> >> # Create the patch file (name depends on the subject line of your patch). >> git format-patch HEAD^ >> # Check the patch (fix any issues which were found). >> scripts/checkpatch.pl 0001-* >> # Get the maintainer who is responsible (there is not always one). >> scripts/get_maintainer.pl 0001-* >> # Send the patch. >> git send-email --to qemu-devel@nongnu.org --to "n.n" >> 0001-* > > If you do this more than once in the same git tree you'll regret it :-) > ("git send-email 0001-*" will happily retransmit all the old 0001-foo > patches along with the new one...) I use git-format-patch's -o option to > put my sent patches in a separate directory so they don't clutter up the > working tree. You can also do: git send-email --to=qemu-devel@nongnu.org HEAD~1 Which avoids any clutter. Regards, Anthony Liguori > >> Please read also http://wiki.qemu.org/Contribute/SubmitAPatch. > > I've updated the wiki page to mention git format-patch and git send-email. > Does anybody have a link to a decent short tutorial on how to use them? > If so, I think it would probably be helpful for us to put a link on the > SubmitAPatch page. > > -- PMM >