From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39940) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SU2TN-0006FL-74 for qemu-devel@nongnu.org; Mon, 14 May 2012 17:06:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SU2TL-0006gM-8Z for qemu-devel@nongnu.org; Mon, 14 May 2012 17:06:28 -0400 Received: from moutng.kundenserver.de ([212.227.126.187]:64637) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SU2TK-0006gD-Vm for qemu-devel@nongnu.org; Mon, 14 May 2012 17:06:27 -0400 Message-ID: <4FB173D7.8050208@rdsoftware.de> Date: Mon, 14 May 2012 23:06:31 +0200 From: Erik Rull MIME-Version: 1.0 References: <4FB1672D.7000906@rdsoftware.de> <4FB16B68.3040307@weilnetz.de> In-Reply-To: <4FB16B68.3040307@weilnetz.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] Posting a patch? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Erik Rull , "qemu-devel@nongnu.org" Stefan Weil wrote: > Am 14.05.2012 22:12, schrieb Erik Rull: >> Hi all, >> >> is there a guideline or manual how to send a patch to the qemu mailing >> list? It seems as if this can be done somehow automagically using the >> local git repository, but I didn't find a tool to do that. >> >> Thanks! >> >> Best regards, >> >> Erik > > Hi Erik, > > if you use git for sending, you don't risk that your mailer destroys the > format of your patch. > I usually use these commands to send a single patch from the QEMU source > directory: > > # Create the patch file (name depends on the subject line of your patch). > git format-patch HEAD^ > # Check the patch (fix any issues which were found). > scripts/checkpatch.pl 0001-* > # Get the maintainer who is responsible (there is not always one). > scripts/get_maintainer.pl 0001-* > # Send the patch. > git send-email --to qemu-devel@nongnu.org --to "n.n " 0001-* > > Please read also http://wiki.qemu.org/Contribute/SubmitAPatch. > > Regards, > > Stefan W. > Thanks! So I started a git pull to get the latest master and as well a git reset --hard to assert that there are no modifications remaining. Then I modified the file ui/x_keymap.c and called then the git format-patch HEAD^ But I get 3 patches that are definitively not related to my changes: erik@debian:~/qemu-test/qemu$ git format-patch HEAD^ 0001-coroutine-Fix-setup-of-sigaltstack-coroutines.patch 0002-qcow2-Don-t-ignore-failure-to-clear-autoclear-flags.patch 0003-qemu-img-Fix-segmentation-fault.patch erik@debian:~/qemu-test/qemu$ Using git diff shows my real changes... So I created a patch file called keymap.patch but git format-patch HEAD^ just ignores it.. Maybe I missed something important... Best regards, Erik