From: Paolo Bonzini <pbonzini@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: "Li Zhi Hui" <zhihuili@linux.vnet.ibm.com>,
"Hervé Poussineau" <hpoussin@reactos.org>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/3 v6] Replace bdrv_* to bdrv_aio_* functions in DMA mode in fdc.c
Date: Tue, 15 May 2012 11:38:13 +0200 [thread overview]
Message-ID: <4FB22405.9060203@redhat.com> (raw)
In-Reply-To: <4FB222FF.8050905@redhat.com>
Il 15/05/2012 11:33, Kevin Wolf ha scritto:
>> > which blindly overwrites status2. Hence the new code was not written
>> > based on it. However, the new code is untested as far as I know.
> In the thread of an earlier version of this series, I said that a qtest
> for floppy is required. This only confirms it.
The problem with writing a qtest is that the spec is incredibly complex
and obscure. It's probably even better to rip out code that cannot be
tested properly, so you don't have to test it at all...
(Mostly tongue-in-cheek of course. A qtest for basic read/write in PIO
and DMA modes is indeed a very good idea).
Paolo
next prev parent reply other threads:[~2012-05-15 9:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 9:17 [Qemu-devel] [PATCH 0/3 v6] Replace bdrv_* to bdrv_aio_* functions in DMA mode in fdc.c Li Zhi Hui
2012-05-15 9:17 ` [Qemu-devel] [PATCH 1/3 v6] add function DMA_set_return and DMA_set_channel_async in dma.c Li Zhi Hui
2012-05-15 9:17 ` [Qemu-devel] [PATCH 2/3 v6] Replace bdrv_* to bdrv_aio_* functions in DMA mode in fdc.c Li Zhi Hui
2012-05-15 9:27 ` Paolo Bonzini
2012-05-15 9:33 ` Kevin Wolf
2012-05-15 9:38 ` Paolo Bonzini [this message]
2012-05-16 8:23 ` Zhi Hui Li
2012-05-16 9:11 ` Paolo Bonzini
2012-05-16 10:59 ` Kevin Wolf
2012-05-15 20:49 ` Hervé Poussineau
2012-05-16 7:58 ` Zhi Hui Li
2012-05-15 9:17 ` [Qemu-devel] [PATCH 3/3 v6] fdc.c: add tracing Li Zhi Hui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB22405.9060203@redhat.com \
--to=pbonzini@redhat.com \
--cc=hpoussin@reactos.org \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhihuili@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).