From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35480) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SUED4-0007zH-GZ for qemu-devel@nongnu.org; Tue, 15 May 2012 05:38:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SUECy-0007xg-C6 for qemu-devel@nongnu.org; Tue, 15 May 2012 05:38:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44497) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SUECy-0007xR-3k for qemu-devel@nongnu.org; Tue, 15 May 2012 05:38:20 -0400 Message-ID: <4FB22405.9060203@redhat.com> Date: Tue, 15 May 2012 11:38:13 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1337073445-9679-1-git-send-email-zhihuili@linux.vnet.ibm.com> <1337073445-9679-3-git-send-email-zhihuili@linux.vnet.ibm.com> <4FB22171.7050104@redhat.com> <4FB222FF.8050905@redhat.com> In-Reply-To: <4FB222FF.8050905@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/3 v6] Replace bdrv_* to bdrv_aio_* functions in DMA mode in fdc.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Li Zhi Hui , =?ISO-8859-15?Q?Herv=E9_P?= =?ISO-8859-15?Q?oussineau?= , qemu-devel@nongnu.org Il 15/05/2012 11:33, Kevin Wolf ha scritto: >> > which blindly overwrites status2. Hence the new code was not written >> > based on it. However, the new code is untested as far as I know. > In the thread of an earlier version of this series, I said that a qtest > for floppy is required. This only confirms it. The problem with writing a qtest is that the spec is incredibly complex and obscure. It's probably even better to rip out code that cannot be tested properly, so you don't have to test it at all... (Mostly tongue-in-cheek of course. A qtest for basic read/write in PIO and DMA modes is indeed a very good idea). Paolo