From: Kevin Wolf <kwolf@redhat.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xen.org>
Subject: Re: [Qemu-devel] [PATCH, v2] qemu/xendisk: properly update stats in ioreq_release()
Date: Tue, 15 May 2012 12:32:24 +0200 [thread overview]
Message-ID: <4FB230B8.9060002@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1205151115240.26786@kaball-desktop>
Am 15.05.2012 12:16, schrieb Stefano Stabellini:
> On Tue, 15 May 2012, Kevin Wolf wrote:
>> Am 14.05.2012 16:57, schrieb Stefano Stabellini:
>>> On Mon, 14 May 2012, Jan Beulich wrote:
>>>> While for the "normal" case (called from blk_send_response_all())
>>>> decrementing requests_finished is correct, doing so in the parse error
>>>> case is wrong; requests_inflight needs to be decremented instead.
>>>>
>>>> Change in v2: Adjust coding style.
>>>>
>>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>>
>>> Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>>
>> Aren't you going to send a pull request yourself, Stefano?
>
> Yes, I am: I am collecting a series of Xen patches for 1.1 and I am
> aiming at sending a single pull request by the end of the week.
>
> http://marc.info/?l=qemu-devel&m=133701567429388&w=2
Ok, great.
I was just wondering because I always understood an Acked-by as a
message to the maintainer who picks the patch up, so I wasn't sure if
you expected me to do it and the patch would fall through the cracks.
Kevin
prev parent reply other threads:[~2012-05-15 10:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 10:30 [Qemu-devel] [PATCH, v2] qemu/xendisk: properly update stats in ioreq_release() Jan Beulich
2012-05-14 11:53 ` Kevin Wolf
2012-05-14 14:57 ` Stefano Stabellini
2012-05-15 8:56 ` Kevin Wolf
2012-05-15 10:16 ` Stefano Stabellini
2012-05-15 10:32 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB230B8.9060002@redhat.com \
--to=kwolf@redhat.com \
--cc=JBeulich@suse.com \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).