From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37851) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SUF3b-0003wn-Ei for qemu-devel@nongnu.org; Tue, 15 May 2012 06:32:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SUF3U-0002ZI-Kw for qemu-devel@nongnu.org; Tue, 15 May 2012 06:32:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34359) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SUF3U-0002Z3-Cb for qemu-devel@nongnu.org; Tue, 15 May 2012 06:32:36 -0400 Message-ID: <4FB230B8.9060002@redhat.com> Date: Tue, 15 May 2012 12:32:24 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <4FB0FAC8020000780008369A@nat28.tlf.novell.com> <4FB21A3F.6060509@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH, v2] qemu/xendisk: properly update stats in ioreq_release() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefano Stabellini Cc: "qemu-devel@nongnu.org" , Jan Beulich , xen-devel Am 15.05.2012 12:16, schrieb Stefano Stabellini: > On Tue, 15 May 2012, Kevin Wolf wrote: >> Am 14.05.2012 16:57, schrieb Stefano Stabellini: >>> On Mon, 14 May 2012, Jan Beulich wrote: >>>> While for the "normal" case (called from blk_send_response_all()) >>>> decrementing requests_finished is correct, doing so in the parse error >>>> case is wrong; requests_inflight needs to be decremented instead. >>>> >>>> Change in v2: Adjust coding style. >>>> >>>> Signed-off-by: Jan Beulich >>> >>> Acked-by: Stefano Stabellini >> >> Aren't you going to send a pull request yourself, Stefano? > > Yes, I am: I am collecting a series of Xen patches for 1.1 and I am > aiming at sending a single pull request by the end of the week. > > http://marc.info/?l=qemu-devel&m=133701567429388&w=2 Ok, great. I was just wondering because I always understood an Acked-by as a message to the maintainer who picks the patch up, so I wasn't sure if you expected me to do it and the patch would fall through the cracks. Kevin