From: Kevin Wolf <kwolf@redhat.com>
To: Qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
Markus Armbruster <armbru@redhat.com>
Subject: [Qemu-devel] Interface for enabling lazy refcount updates in qcow2
Date: Tue, 15 May 2012 14:01:23 +0200 [thread overview]
Message-ID: <4FB24593.5050106@redhat.com> (raw)
Hi all,
after having implemented refcount fixing in qcow2's img_check, I'm now
wondering what the best way is to allow users to optionally enable the
"QED mode" for cache=writethrough images where refcount updates aren't
written out immediately.
Basically the two options are:
1. Store it in the image with a compatible feature flag and require
that the flag is set during image creation (and never updated)
2. Have an option on the command line and pass it each time you start
a VM and want to enable it
I'm leaning towards option 2 because it is more flexible and consistent
with the other caching options that aren't stored in the image file
either. It's a bit ugly with -drive because it would add a new option
that is invalid/ignored for everything except qcow2.
Or maybe instead of a new option, add a cache mode almost-writethrough?
(I'm having a hard time finding a good name...) But then, we're already
trying to get rid of the cache option and replace it by three separate
switches, so adding a fourth dimension might not be the smartest move ever.
(The correct solution is, of course, -blockdev which would allow
per-driver runtime options, but well...)
Kevin
next reply other threads:[~2012-05-15 12:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 12:01 Kevin Wolf [this message]
2012-05-15 12:42 ` [Qemu-devel] Interface for enabling lazy refcount updates in qcow2 Paolo Bonzini
2012-05-21 14:34 ` Stefan Hajnoczi
2012-05-21 15:23 ` Kevin Wolf
2012-05-23 10:45 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB24593.5050106@redhat.com \
--to=kwolf@redhat.com \
--cc=Qemu-devel@nongnu.org \
--cc=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).