From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60383)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SUHZN-0000DV-OH
	for qemu-devel@nongnu.org; Tue, 15 May 2012 09:13:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SUHZD-0000Fl-F5
	for qemu-devel@nongnu.org; Tue, 15 May 2012 09:13:41 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50427)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SUHZD-0000Fc-6f
	for qemu-devel@nongnu.org; Tue, 15 May 2012 09:13:31 -0400
Message-ID: <4FB2566B.4080708@redhat.com>
Date: Tue, 15 May 2012 15:13:15 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1337087078-24056-1-git-send-email-jim@meyering.net>
	<1337087078-24056-3-git-send-email-jim@meyering.net>
In-Reply-To: <1337087078-24056-3-git-send-email-jim@meyering.net>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/3] scsi, pci, qdev, isa-bus,
 sysbus: don't let *_get_fw_dev_path return NULL
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: jim@meyering.net
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <aliguori@us.ibm.com>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, "Michael S. Tsirkin" <mst@redhat.com>, Jim Meyering <meyering@redhat.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, =?ISO-8859-15?Q?Herv=E9_Poussineau?= <hpoussin@reactos.org>, Avi Kivity <avi@redhat.com>, =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>, Floris Bos <dev@noc-ps.com>, Richard Henderson <rth@twiddle.net>

Il 15/05/2012 15:04, jim@meyering.net ha scritto:
> diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c
> index 8ab9bcd..a4e93d1 100644
> --- a/hw/scsi-bus.c
> +++ b/hw/scsi-bus.c
> @@ -1470,12 +1470,8 @@ static char *scsibus_get_dev_path(DeviceState *dev)
>  static char *scsibus_get_fw_dev_path(DeviceState *dev)
>  {
>      SCSIDevice *d = SCSI_DEVICE(dev);
> -    char path[100];
> -
> -    snprintf(path, sizeof(path), "channel@%x/%s@%x,%x", d->channel,
> -             qdev_fw_name(dev), d->id, d->lun);
> -
> -    return strdup(path);
> +    return g_strdup_printf("channel@%x/%s@%x,%x", d->channel,
> +                           qdev_fw_name(dev), d->id, d->lun);
>  }
> 
>  SCSIDevice *scsi_device_find(SCSIBus *bus, int channel, int id, int lun)

Acked-by: Paolo Bonzini <pbonzini@redhat.com>

I'm assuming that these will be handled by a global committer.

Paolo