From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:40661)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1SUHvH-0007i8-Up
	for qemu-devel@nongnu.org; Tue, 15 May 2012 09:36:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1SUHv7-0007jw-Pf
	for qemu-devel@nongnu.org; Tue, 15 May 2012 09:36:19 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59543)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1SUHv7-0007jU-I8
	for qemu-devel@nongnu.org; Tue, 15 May 2012 09:36:09 -0400
Message-ID: <4FB25BBC.3070901@redhat.com>
Date: Tue, 15 May 2012 15:35:56 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1337087078-24056-1-git-send-email-jim@meyering.net>
	<1337087078-24056-3-git-send-email-jim@meyering.net>
In-Reply-To: <1337087078-24056-3-git-send-email-jim@meyering.net>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/3] scsi, pci, qdev, isa-bus,
 sysbus: don't let *_get_fw_dev_path return NULL
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: jim@meyering.net
Cc: Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <aliguori@us.ibm.com>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, "Michael S. Tsirkin" <mst@redhat.com>, Jim Meyering <meyering@redhat.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, =?ISO-8859-15?Q?Herv=E9_Poussineau?= <hpoussin@reactos.org>, Avi Kivity <avi@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>, Floris Bos <dev@noc-ps.com>, Richard Henderson <rth@twiddle.net>

Am 15.05.2012 15:04, schrieb jim@meyering.net:
> From: Jim Meyering <meyering@redhat.com>
> 
> Use g_strdup rather than strdup, because the sole caller
> (qdev_get_fw_dev_path_helper) assumes it gets non-NULL, and dereferences
> it.  Besides, in that caller, the allocated buffer is already freed with
> g_free, so it's better to allocate with a matching g_strdup.
> 
> In one case, (scsi-bus.c) it was trivial, so I replaced an snprintf+
> g_strdup combination with an equivalent g_strdup_printf use.
> 
> Signed-off-by: Jim Meyering <meyering@redhat.com>

Acked-by: Kevin Wolf <kwolf@redhat.com>