From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35970) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SUKZj-0008Vo-Kj for qemu-devel@nongnu.org; Tue, 15 May 2012 12:26:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SUKZd-0007Vy-D4 for qemu-devel@nongnu.org; Tue, 15 May 2012 12:26:15 -0400 Received: from mail-ob0-f173.google.com ([209.85.214.173]:55001) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SUKZd-0007VJ-5P for qemu-devel@nongnu.org; Tue, 15 May 2012 12:26:09 -0400 Received: by obbwd20 with SMTP id wd20so11133626obb.4 for ; Tue, 15 May 2012 09:26:07 -0700 (PDT) Message-ID: <4FB2839B.3000103@codemonkey.ws> Date: Tue, 15 May 2012 11:26:03 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1337095599-28836-1-git-send-email-anthony.perard@citrix.com> In-Reply-To: <1337095599-28836-1-git-send-email-anthony.perard@citrix.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1.1 0/4] Xen: Fix PV-on-HVM List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony PERARD Cc: Stefano Stabellini , "Michael S. Tsirkin" , QEMU-devel , Xen Devel On 05/15/2012 10:26 AM, Anthony PERARD wrote: > In the context of PV-on-HVM under Xen, the emulated nics are supposed to be > unplug before the guest drivers are initialized. This mean that there must be > unplug without the consent of the guest. Stefano, Can you do a PULL for the various 1.1 fixes for Xen? Please try to get any -rc3 pull requests in by Friday. Thanks, Anthony Liguori > > Without this patch series, the guest end up with two nics with the same MAC, > the emulated nic and the PV nic. > > I tried few other path before to submite these patches: > - delayed the hot unplug in QEMU until the guest initialize the hotplug. > => the guest unplug the nic only after the driver initialized it. That's a > bit late. > - delayed the call to unplug the emulated device until pci_acpi_init is called > => this is worse, the pv disc does not show up and the guest does not boot. > > In order to achive this fix, these patches introduce a new hotplug state only > used in acpi_piix4, and a new qdev callback force_unplug. > > Would it be possible to have this fix in the next release? > > Thanks, > > > Anthony PERARD (4): > Introduce a new hotplug state: Force eject. > qdev: Introduce qdev_force_unplug. > pci: Add force_unplug callback. > xen: Fix PV-on-HVM > > hw/acpi_piix4.c | 5 +++++ > hw/pci.c | 15 +++++++++++++-- > hw/pci.h | 1 + > hw/qdev.c | 23 ++++++++++++++++++++--- > hw/qdev.h | 3 +++ > hw/xen_platform.c | 2 +- > 6 files changed, 43 insertions(+), 6 deletions(-) >