From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:55749)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <B07421@freescale.com>) id 1SUNfL-0001Kh-2H
	for qemu-devel@nongnu.org; Tue, 15 May 2012 15:44:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <B07421@freescale.com>) id 1SUNfJ-0007os-Dc
	for qemu-devel@nongnu.org; Tue, 15 May 2012 15:44:14 -0400
Received: from tx2ehsobe002.messaging.microsoft.com ([65.55.88.12]:21430
	helo=tx2outboundpool.messaging.microsoft.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <B07421@freescale.com>) id 1SUNfJ-0007og-7m
	for qemu-devel@nongnu.org; Tue, 15 May 2012 15:44:13 -0400
Message-ID: <4FB2B206.4010803@freescale.com>
Date: Tue, 15 May 2012 14:44:06 -0500
From: Scott Wood <scottwood@freescale.com>
MIME-Version: 1.0
References: <20110707234405.GC6748@schlenkerla.am.freescale.net>
	<4FA7EE80.90801@adacore.com>
	<33FEFA18-85CE-4222-A7EB-50C77E379727@suse.de>
	<4FAA4CD7.7090705@adacore.com> <4FB27612.3040705@freescale.com>
	<4FB28972.10800@adacore.com>
In-Reply-To: <4FB28972.10800@adacore.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/4] ppc: booke206: use MAV=2.0 TSIZE
 definition, fix 4G pages
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fabien Chouteau <chouteau@adacore.com>
Cc: Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org

On 05/15/2012 11:50 AM, Fabien Chouteau wrote:
> On 05/15/2012 05:28 PM, Scott Wood wrote:
>> On 05/09/2012 05:54 AM, Fabien Chouteau wrote:
>>> On 05/07/2012 06:28 PM, Alexander Graf wrote:
>>>> Hi Fabien,
>>>>
>>>> Could you please elaborate a bit on the case that broke for you with these? The patches shouldn't change any guest facing behavior :o.
>>>>
>>>>
>>>
>>> My bad,
>>>
>>> The problem comes from my initialization of tlb entries at board reset.
>>> I use MAS1_TSIZE_SHIFT:
>>>
>>>     size = 0x1 << MAS1_TSIZE_SHIFT; /* 4 KBytes */
>>>
>>> but since the definition as changed, the value is incorrect. It should
>>> be:
>>>
>>>     size = 0x10 << MAS1_TSIZE_SHIFT; /* 4 KBytes */
>>
>> You should be using booke206_bytes_to_tsize(), or perhaps create some
>> #defines for the various tsizes.
>>
> 
> Do you mean booke206_page_size_to_tlb()?

No, I was referring to something on an internal branch, sorry.

-Scott