From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:48949)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SUVWJ-0007mA-6K
	for qemu-devel@nongnu.org; Wed, 16 May 2012 00:07:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SUVWH-000757-BP
	for qemu-devel@nongnu.org; Wed, 16 May 2012 00:07:26 -0400
Received: from cantor2.suse.de ([195.135.220.15]:60946 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SUVWH-00074v-5U
	for qemu-devel@nongnu.org; Wed, 16 May 2012 00:07:25 -0400
Message-ID: <4FB327F7.5020302@suse.de>
Date: Wed, 16 May 2012 06:07:19 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1337098785-32024-1-git-send-email-sw@weilnetz.de>
In-Reply-To: <1337098785-32024-1-git-send-email-sw@weilnetz.de>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 1.1] tests: Add rtc-test (fix test
	regression)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>
Cc: Kevin Wolf <kwolf@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org

Am 15.05.2012 18:19, schrieb Stefan Weil:
> Commit 93e9eb6808c886f5f1c903b7ced1eed65de2ba39 added fdc-test,
> but accidentally removed rtc-test because check-qtest-i386-y was
> not enhanced but set twice.
>=20
> This patch adds rtc-test again (and sorts both tests alphabetically).
>=20
> Signed-off-by: Stefan Weil <sw@weilnetz.de>

Reviewed-by: Andreas F=E4rber <afaerber@suse.de>

I wonder though if it might be better to always just use +=3D because
especially an alphabetical order risks us introducing the same fault agai=
n.

Andreas

> ---
>  tests/Makefile |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/tests/Makefile b/tests/Makefile
> index f1b317a..ab7f667 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -18,8 +18,8 @@ check-block-$(CONFIG_POSIX) +=3D tests/qemu-iotests-q=
uick.sh
> =20
>  # All QTests for now are POSIX-only, but the dependencies are
>  # really in libqtest, not in the testcases themselves.
> -check-qtest-i386-y =3D tests/rtc-test$(EXESUF)
>  check-qtest-i386-y =3D tests/fdc-test$(EXESUF)
> +check-qtest-i386-y +=3D tests/rtc-test$(EXESUF)
>  check-qtest-x86_64-y =3D $(check-qtest-i386-y)
>  check-qtest-sparc-y =3D tests/m48t59-test$(EXESUF)
>  check-qtest-sparc64-y =3D tests/m48t59-test$(EXESUF)

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg