* [Qemu-devel] [PATCH 1.1] tests: Add rtc-test (fix test regression)
@ 2012-05-15 16:19 Stefan Weil
2012-05-16 4:07 ` Andreas Färber
2012-05-19 19:03 ` Blue Swirl
0 siblings, 2 replies; 4+ messages in thread
From: Stefan Weil @ 2012-05-15 16:19 UTC (permalink / raw)
To: Anthony Liguori; +Cc: Kevin Wolf, Paolo Bonzini, qemu-devel, Stefan Weil
Commit 93e9eb6808c886f5f1c903b7ced1eed65de2ba39 added fdc-test,
but accidentally removed rtc-test because check-qtest-i386-y was
not enhanced but set twice.
This patch adds rtc-test again (and sorts both tests alphabetically).
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
tests/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/Makefile b/tests/Makefile
index f1b317a..ab7f667 100644
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -18,8 +18,8 @@ check-block-$(CONFIG_POSIX) += tests/qemu-iotests-quick.sh
# All QTests for now are POSIX-only, but the dependencies are
# really in libqtest, not in the testcases themselves.
-check-qtest-i386-y = tests/rtc-test$(EXESUF)
check-qtest-i386-y = tests/fdc-test$(EXESUF)
+check-qtest-i386-y += tests/rtc-test$(EXESUF)
check-qtest-x86_64-y = $(check-qtest-i386-y)
check-qtest-sparc-y = tests/m48t59-test$(EXESUF)
check-qtest-sparc64-y = tests/m48t59-test$(EXESUF)
--
1.7.10
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH 1.1] tests: Add rtc-test (fix test regression)
2012-05-15 16:19 [Qemu-devel] [PATCH 1.1] tests: Add rtc-test (fix test regression) Stefan Weil
@ 2012-05-16 4:07 ` Andreas Färber
2012-05-16 11:00 ` Kevin Wolf
2012-05-19 19:03 ` Blue Swirl
1 sibling, 1 reply; 4+ messages in thread
From: Andreas Färber @ 2012-05-16 4:07 UTC (permalink / raw)
To: Stefan Weil; +Cc: Kevin Wolf, Paolo Bonzini, Anthony Liguori, qemu-devel
Am 15.05.2012 18:19, schrieb Stefan Weil:
> Commit 93e9eb6808c886f5f1c903b7ced1eed65de2ba39 added fdc-test,
> but accidentally removed rtc-test because check-qtest-i386-y was
> not enhanced but set twice.
>
> This patch adds rtc-test again (and sorts both tests alphabetically).
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Andreas Färber <afaerber@suse.de>
I wonder though if it might be better to always just use += because
especially an alphabetical order risks us introducing the same fault again.
Andreas
> ---
> tests/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/Makefile b/tests/Makefile
> index f1b317a..ab7f667 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -18,8 +18,8 @@ check-block-$(CONFIG_POSIX) += tests/qemu-iotests-quick.sh
>
> # All QTests for now are POSIX-only, but the dependencies are
> # really in libqtest, not in the testcases themselves.
> -check-qtest-i386-y = tests/rtc-test$(EXESUF)
> check-qtest-i386-y = tests/fdc-test$(EXESUF)
> +check-qtest-i386-y += tests/rtc-test$(EXESUF)
> check-qtest-x86_64-y = $(check-qtest-i386-y)
> check-qtest-sparc-y = tests/m48t59-test$(EXESUF)
> check-qtest-sparc64-y = tests/m48t59-test$(EXESUF)
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH 1.1] tests: Add rtc-test (fix test regression)
2012-05-16 4:07 ` Andreas Färber
@ 2012-05-16 11:00 ` Kevin Wolf
0 siblings, 0 replies; 4+ messages in thread
From: Kevin Wolf @ 2012-05-16 11:00 UTC (permalink / raw)
To: Andreas Färber
Cc: Stefan Weil, Anthony Liguori, qemu-devel, Paolo Bonzini
Am 16.05.2012 06:07, schrieb Andreas Färber:
> Am 15.05.2012 18:19, schrieb Stefan Weil:
>> Commit 93e9eb6808c886f5f1c903b7ced1eed65de2ba39 added fdc-test,
>> but accidentally removed rtc-test because check-qtest-i386-y was
>> not enhanced but set twice.
>>
>> This patch adds rtc-test again (and sorts both tests alphabetically).
>>
>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>
> Reviewed-by: Andreas Färber <afaerber@suse.de>
>
> I wonder though if it might be better to always just use += because
> especially an alphabetical order risks us introducing the same fault again.
Yes, I think that would be better.
Kevin
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH 1.1] tests: Add rtc-test (fix test regression)
2012-05-15 16:19 [Qemu-devel] [PATCH 1.1] tests: Add rtc-test (fix test regression) Stefan Weil
2012-05-16 4:07 ` Andreas Färber
@ 2012-05-19 19:03 ` Blue Swirl
1 sibling, 0 replies; 4+ messages in thread
From: Blue Swirl @ 2012-05-19 19:03 UTC (permalink / raw)
To: Stefan Weil; +Cc: Kevin Wolf, Paolo Bonzini, Anthony Liguori, qemu-devel
Thanks, applied.
On Tue, May 15, 2012 at 4:19 PM, Stefan Weil <sw@weilnetz.de> wrote:
> Commit 93e9eb6808c886f5f1c903b7ced1eed65de2ba39 added fdc-test,
> but accidentally removed rtc-test because check-qtest-i386-y was
> not enhanced but set twice.
>
> This patch adds rtc-test again (and sorts both tests alphabetically).
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> tests/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/Makefile b/tests/Makefile
> index f1b317a..ab7f667 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -18,8 +18,8 @@ check-block-$(CONFIG_POSIX) += tests/qemu-iotests-quick.sh
>
> # All QTests for now are POSIX-only, but the dependencies are
> # really in libqtest, not in the testcases themselves.
> -check-qtest-i386-y = tests/rtc-test$(EXESUF)
> check-qtest-i386-y = tests/fdc-test$(EXESUF)
> +check-qtest-i386-y += tests/rtc-test$(EXESUF)
> check-qtest-x86_64-y = $(check-qtest-i386-y)
> check-qtest-sparc-y = tests/m48t59-test$(EXESUF)
> check-qtest-sparc64-y = tests/m48t59-test$(EXESUF)
> --
> 1.7.10
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-05-19 19:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-15 16:19 [Qemu-devel] [PATCH 1.1] tests: Add rtc-test (fix test regression) Stefan Weil
2012-05-16 4:07 ` Andreas Färber
2012-05-16 11:00 ` Kevin Wolf
2012-05-19 19:03 ` Blue Swirl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).