From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:54678)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SUcKX-0000qa-4e
	for qemu-devel@nongnu.org; Wed, 16 May 2012 07:23:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SUcKU-0003SR-9k
	for qemu-devel@nongnu.org; Wed, 16 May 2012 07:23:44 -0400
Received: from mail-pb0-f45.google.com ([209.85.160.45]:35704)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SUcKU-0003SF-0i
	for qemu-devel@nongnu.org; Wed, 16 May 2012 07:23:42 -0400
Received: by pbbro12 with SMTP id ro12so1258298pbb.4
	for <qemu-devel@nongnu.org>; Wed, 16 May 2012 04:23:39 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4FB38E2E.5000508@redhat.com>
Date: Wed, 16 May 2012 13:23:26 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1337095599-28836-1-git-send-email-anthony.perard@citrix.com>
	<1337095599-28836-2-git-send-email-anthony.perard@citrix.com>
	<20120515205222.GA12039@redhat.com>
	<alpine.DEB.2.00.1205161124090.26786@kaball-desktop>
	<CAJJyHjKHn5HA6y0B8oHP7o2W=6_wd-0vpLzkeM74-ZYypn+tAA@mail.gmail.com>
In-Reply-To: <CAJJyHjKHn5HA6y0B8oHP7o2W=6_wd-0vpLzkeM74-ZYypn+tAA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force
	eject.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Xen Devel <xen-devel@lists.xen.org>, "Michael S. Tsirkin" <mst@redhat.com>, QEMU-devel <qemu-devel@nongnu.org>, Anthony Liguori <anthony@codemonkey.ws>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>

Il 16/05/2012 13:15, Anthony PERARD ha scritto:
>> >         qdev_unplug(&(d->qdev), NULL);
>> > +        qdev_free(&(d->qdev));
>> >     }
>> >  }
>> >
>> >
>> > Anthony, can you confirm that this solves the problem for you?
> This work until I try to hotplug a new device to the guest at wish
> point I have this:
> ERROR:/local/home/anthony/work/qemu/qom/object.c:389:object_delete:
> assertion failed: (obj->ref == 0)
> 
> This is because there is still a pending request of the hotunplug in
> the acpi piix4.
> If I call qdev_free without qdev_unplug, I hit the same assert, but
> rigth away. This is way something new.

Because it's missing the object_unparent done by qdev_unplug.  Does
object_unparent+qdev_free work?  (I believe object_unparent should be
done by qdev_free rather than qdev_unplug, but that's something for 1.2).

Paolo