From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:50604)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SUgWh-0005EI-7Z
	for qemu-devel@nongnu.org; Wed, 16 May 2012 11:52:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SUgWY-0006dE-Qu
	for qemu-devel@nongnu.org; Wed, 16 May 2012 11:52:34 -0400
Received: from mail-pz0-f45.google.com ([209.85.210.45]:51635)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SUgWY-0006cq-IX
	for qemu-devel@nongnu.org; Wed, 16 May 2012 11:52:26 -0400
Received: by dadv2 with SMTP id v2so1496812dad.4
	for <qemu-devel@nongnu.org>; Wed, 16 May 2012 08:52:24 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4FB3CD31.8050903@redhat.com>
Date: Wed, 16 May 2012 17:52:17 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1337095599-28836-1-git-send-email-anthony.perard@citrix.com>
	<1337095599-28836-2-git-send-email-anthony.perard@citrix.com>
	<20120515205222.GA12039@redhat.com>
	<alpine.DEB.2.00.1205161124090.26786@kaball-desktop>
	<CAJJyHjKHn5HA6y0B8oHP7o2W=6_wd-0vpLzkeM74-ZYypn+tAA@mail.gmail.com>
	<4FB38E2E.5000508@redhat.com>
	<CAJJyHj+AOgGDUfKKkJa0R=kjokeN5dcz8yEXQPjnXsCrOQ52Dw@mail.gmail.com>
	<20120516132017.GB8620@redhat.com>
In-Reply-To: <20120516132017.GB8620@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force
	eject.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Anthony PERARD <anthony.perard@citrix.com>, Xen Devel <xen-devel@lists.xen.org>, QEMU-devel <qemu-devel@nongnu.org>, Anthony Liguori <anthony@codemonkey.ws>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>

Il 16/05/2012 15:20, Michael S. Tsirkin ha scritto:
>>> Because it's missing the object_unparent done by qdev_unplug.  Does
>>> object_unparent+qdev_free work?  (I believe object_unparent should be
>>> done by qdev_free rather than qdev_unplug, but that's something for 1.2).
>>
>> Cool, this seems to work fine. Thanks.
>>
>> I'll test a bit more and resend a patch with only object_unparent+qdev_free.
> 
> Separately it was suggested to make qdev_free do object_unparent
> automatically. Anthony is yet to respond.

Yes, but for 1.1 this Xen-only patch would be nice.

Paolo