From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40536) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SUgi8-0001QG-PM for qemu-devel@nongnu.org; Wed, 16 May 2012 12:04:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SUgi2-0002Vl-Bp for qemu-devel@nongnu.org; Wed, 16 May 2012 12:04:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39485) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SUgi2-0002Ur-3R for qemu-devel@nongnu.org; Wed, 16 May 2012 12:04:18 -0400 Message-ID: <4FB3CFFD.5090605@redhat.com> Date: Wed, 16 May 2012 10:04:13 -0600 From: Eric Blake MIME-Version: 1.0 References: <1337172904-20508-1-git-send-email-berrange@redhat.com> In-Reply-To: <1337172904-20508-1-git-send-email-berrange@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig49583C52FDF5FDDBEB2B1013" Subject: Re: [Qemu-devel] [PATCH] Add 'query-events' command to QMP to query async events List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: Luiz Capitulino , qemu-devel@nongnu.org, Anthony Liguori , Markus Armbruster This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig49583C52FDF5FDDBEB2B1013 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/16/2012 06:55 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" >=20 > Sometimes it is neccessary for an application to determine > whether a particular QMP event is available, so they can > decide whether to use compatibility code instead. This > introduces a new 'query-events' command to QMP todo just s/todo/to do/ > that >=20 > { "execute": "query-events" } > {"return": [{"name": "WAKEUP"}, > {"name": "SUSPEND"}, > {"name": "DEVICE_TRAY_MOVED"}, > {"name": "BLOCK_JOB_CANCELLED"}, > {"name": "BLOCK_JOB_COMPLETED"}, > ...snip... > {"name": "SHUTDOWN"}]} >=20 > * monitor.c: Split out MonitorEvent -> string conversion > into monitor_protocol_event_name() API. Add impl of > qmp_query_events monitor command handler > * qapi-schema.json, qmp-commands.hx: Define contract of > query-events command Definitely useful for libvirt. > +static const char *monitor_protocol_event_name(MonitorEvent event) > +{ > switch (event) { > case QEVENT_SHUTDOWN: > - event_name =3D "SHUTDOWN"; > + return "SHUTDOWN"; > break; These 'break' statements are now unreachable; does this matter in qemu coding style? > +query-events > +-------------- > + > +List QMP available events. > + > +Each event is represented by a json-object, the returned value is a js= on-array > +of all events. > + > +Each json-object contain: s/contain/contains/ --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig49583C52FDF5FDDBEB2B1013 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJPs8/9AAoJEKeha0olJ0NqZdkH/25+aaPLfLWyX5UsVjbjAbcs BCIfih243Ar2H7wP9bOnxjh4VNW+qDvvrzxdjXTFKYCswcxjlXZz+bW3o5DbXbff 49aZtNho5UJUFkqhil33BVG2/rN9ZBR8evf2uo3qsc/pyg6lHWdWj/sipzgln/cX +hPUDW4PJd3OiHx9UhAgY0MCG6RpWCHpGTJz9TmpfnfWfus4uZVVFXan+l2Cxl1l TUn1AQi3igHt7YzqUZOlIx4ayA1dv9bQMdNQNGuuSRpadi98uf3OHQ0ROoC33bmV xcP6fqkrpZn7BxoEPh3RV00hgvwPFk/pYDsFLblWVlu4/noQp8M+aBWURaCrI/I= =cQu2 -----END PGP SIGNATURE----- --------------enig49583C52FDF5FDDBEB2B1013--