From: Paolo Bonzini <pbonzini@redhat.com>
To: "Zhang, Yang Z" <yang.z.zhang@intel.com>
Cc: "'aliguori@us.ibm.com'" <aliguori@us.ibm.com>,
"'qemu-devel@nongnu.org'" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v6 4/7] RTC: Add divider reset support
Date: Thu, 17 May 2012 12:29:29 +0200 [thread overview]
Message-ID: <4FB4D309.10107@redhat.com> (raw)
In-Reply-To: <A9667DDFB95DB7438FA9D7D576C3D87E13A7FC@SHSMSX101.ccr.corp.intel.com>
Il 17/05/2012 04:28, Zhang, Yang Z ha scritto:
>
> +static int32_t divider_reset;
This must be a variable inside RTCState.
The remark about inlining rtc_set_offset applies here as well.
Paolo
> +static inline bool rtc_running(RTCState *s)
> +{
> + return (!(s->cmos_data[RTC_REG_B] & REG_B_SET) &&
> + (s->cmos_data[RTC_REG_A] & 0x70) <= 0x20);
> +}
> +
prev parent reply other threads:[~2012-05-17 10:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-17 2:28 [Qemu-devel] [PATCH v6 4/7] RTC: Add divider reset support Zhang, Yang Z
2012-05-17 10:29 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB4D309.10107@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).