From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33574)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SUxxj-0003Ep-Vh
	for qemu-devel@nongnu.org; Thu, 17 May 2012 06:29:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SUxxf-0006Iw-BW
	for qemu-devel@nongnu.org; Thu, 17 May 2012 06:29:39 -0400
Received: from mx1.redhat.com ([209.132.183.28]:65061)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SUxxf-0006In-3H
	for qemu-devel@nongnu.org; Thu, 17 May 2012 06:29:35 -0400
Message-ID: <4FB4D309.10107@redhat.com>
Date: Thu, 17 May 2012 12:29:29 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <A9667DDFB95DB7438FA9D7D576C3D87E13A7FC@SHSMSX101.ccr.corp.intel.com>
In-Reply-To: <A9667DDFB95DB7438FA9D7D576C3D87E13A7FC@SHSMSX101.ccr.corp.intel.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v6 4/7] RTC: Add divider reset support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Zhang, Yang Z" <yang.z.zhang@intel.com>
Cc: "'aliguori@us.ibm.com'" <aliguori@us.ibm.com>, "'qemu-devel@nongnu.org'" <qemu-devel@nongnu.org>

Il 17/05/2012 04:28, Zhang, Yang Z ha scritto:
> 
> +static int32_t divider_reset;

This must be a variable inside RTCState.

The remark about inlining rtc_set_offset applies here as well.

Paolo

> +static inline bool rtc_running(RTCState *s)
> +{
> +    return (!(s->cmos_data[RTC_REG_B] & REG_B_SET) &&
> +            (s->cmos_data[RTC_REG_A] & 0x70) <= 0x20);
> +}
> +