From: Eric Blake <eblake@redhat.com>
To: "Richard W.M. Jones" <rjones@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3] qemu-img: Implement 'diff' operation.
Date: Thu, 17 May 2012 09:49:47 -0600 [thread overview]
Message-ID: <4FB51E1B.9080602@redhat.com> (raw)
In-Reply-To: <1337268840-4779-1-git-send-email-rjones@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1137 bytes --]
On 05/17/2012 09:34 AM, Richard W.M. Jones wrote:
> From: "Richard W.M. Jones" <rjones@redhat.com>
>
> This produces a qcow2 file which is the difference between
> two disk images. ie, if:
>
> base.img - is a disk image (in any format)
> modified.img - is base.img, copied and modified
>
> then:
>
> qemu-img diff -b base.img modified.img diff.qcow2
>
> creates 'diff.qcow2' which contains the differences between 'base.img'
> and 'modified.img'. Note that 'diff.qcow2' has 'base.img' as its
> backing file.
>
> Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
> Cc: Matthew Booth <mbooth@redhat.com>
> Cc: Pablo Iranzo Gómez <Pablo.Iranzo@redhat.com>
> Cc: Tomas Von Veschler <tvvcox@redhat.com>
Regarding the documentation and command overview:
Reviewed-by: Eric Blake <eblake@redhat.com>
Regarding the actual logic used in computing the diff, I did not closely
look at that, and you would be wise to get a review from someone more
familiar with block dev operations.
--
Eric Blake eblake@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]
next prev parent reply other threads:[~2012-05-17 15:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-17 15:34 [Qemu-devel] [PATCH v3] qemu-img: Implement 'diff' operation Richard W.M. Jones
2012-05-17 15:49 ` Eric Blake [this message]
2012-05-21 13:29 ` Kevin Wolf
2012-05-21 13:59 ` Richard W.M. Jones
2012-05-21 14:06 ` Kevin Wolf
2012-05-21 15:30 ` Eric Blake
2012-05-21 15:40 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB51E1B.9080602@redhat.com \
--to=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).