From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36959) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SVB2W-0004Bj-Ir for qemu-devel@nongnu.org; Thu, 17 May 2012 20:27:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SVB1Y-0000c8-Mk for qemu-devel@nongnu.org; Thu, 17 May 2012 20:27:28 -0400 Received: from e38.co.us.ibm.com ([32.97.110.159]:55812) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SVB1Y-0000bf-F6 for qemu-devel@nongnu.org; Thu, 17 May 2012 20:26:28 -0400 Received: from /spool/local by e38.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 17 May 2012 18:26:23 -0600 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id D03AE1FF001D for ; Thu, 17 May 2012 18:26:17 -0600 (MDT) Received: from d03av05.boulder.ibm.com (d03av05.boulder.ibm.com [9.17.195.85]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q4I0QJmD190566 for ; Thu, 17 May 2012 18:26:20 -0600 Received: from d03av05.boulder.ibm.com (loopback [127.0.0.1]) by d03av05.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q4I0QJ93019714 for ; Thu, 17 May 2012 18:26:19 -0600 Message-ID: <4FB59729.7050106@us.ibm.com> Date: Thu, 17 May 2012 19:26:17 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <4EC02384-64EF-4514-975C-A3D229B3693E@suse.de> <1336055277-53204-1-git-send-email-borntraeger@de.ibm.com> <4FB3818F.1030603@de.ibm.com> <46D681A2-E856-4E7D-9DA7-DC64BA3CAED2@suse.de> In-Reply-To: <46D681A2-E856-4E7D-9DA7-DC64BA3CAED2@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Fix size checking in load_image_targphys to accept max_size > INT_MAX List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Christian Borntraeger , QEMU Developers , Peter Maydell On 05/17/2012 07:18 PM, Alexander Graf wrote: > > On 16.05.2012, at 12:29, Christian Borntraeger wrote: > >> On 03/05/12 16:33, Peter Maydell wrote: >>> On 3 May 2012 15:27, Christian Borntraeger wrote: >>>> commit 17df768c1e4580f03301d18ea938d3557d441911 >>>> load_image_targphys() should enforce the max size >>>> >>>> caused some problems with external kernel and specific ram sizes on s390: >>>> >>>> We load the external kernel with >>>> >>>> [...] >>>> kernel_size = load_image_targphys(kernel_filename, 0, ram_size); >>>> [...] >>>> >>>> Since load_image_targphys is declared as taking an int for max_sz, this will >>>> fail for ram sizes> INT_MAX. >>>> Lets change the max_sz parameter to a uint64_t. >>>> >>>> Signed-off-by: Christian Borntraeger >>> >>> A patch equivalent to this has already been submitted: >>> http://patchwork.ozlabs.org/patch/146165/ >>> We should be applying that one, it has already been reviewed. >>> >>> Anthony? >> >> Anthony, >> >> can you apply the patchwork patch for 1.1? > > Ping? Still missing in rc2. Ack. Regards, Anthony Liguori > > > Alex >