From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37515) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SVB3T-0004ue-IC for qemu-devel@nongnu.org; Thu, 17 May 2012 20:28:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SVB3R-00015w-S8 for qemu-devel@nongnu.org; Thu, 17 May 2012 20:28:27 -0400 Received: from e1.ny.us.ibm.com ([32.97.182.141]:60925) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SVB3R-00015K-NT for qemu-devel@nongnu.org; Thu, 17 May 2012 20:28:25 -0400 Received: from /spool/local by e1.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 17 May 2012 20:28:22 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id DB3146E8049 for ; Thu, 17 May 2012 20:28:20 -0400 (EDT) Received: from d03av05.boulder.ibm.com (d03av05.boulder.ibm.com [9.17.195.85]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q4I0SKjH137300 for ; Thu, 17 May 2012 20:28:20 -0400 Received: from d03av05.boulder.ibm.com (loopback [127.0.0.1]) by d03av05.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q4I0SJVg023072 for ; Thu, 17 May 2012 18:28:20 -0600 Message-ID: <4FB597A2.7030600@us.ibm.com> Date: Thu, 17 May 2012 19:28:18 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <4FA27AE4.4050105@us.ibm.com> <59ABF71D-B380-40F0-B00E-1F60BBB05B93@suse.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Fix legacy device aliases for s390 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Paolo Bonzini , qemu-devel@nongnu.org, Christian Borntraeger On 05/17/2012 05:57 PM, Alexander Graf wrote: > > On 03.05.2012, at 15:34, Alexander Graf wrote: > >> >> On 03.05.2012, at 14:32, Anthony Liguori wrote: >> >>> On 05/03/2012 04:07 AM, Alexander Graf wrote: >>>> >>>> On 03.05.2012, at 11:05, Paolo Bonzini wrote: >>>> >>>>> >>>>>>> The usual old fix was to not even compile them in. Why are they in >>>>>>> the alias list in the s390 build now? >>>>>> >>>>>> Because the alias list is in target-independent code. >>>>>> >>>>>> The old fix was brittle anyway, it dependent on the fact that >>>>>> virtio-blk-pci was not part of libhw. A similar trick broke for >>>>>> cirrus-vga when it became part of libhw. >>>>>> >>>>>> Christian fix is correct. >>>>> >>>>> Uhm, Christian fix would have the same problem actually if >>>>> virtio-*-pci were to be moved in libhw. IIRC I proposed the >>>>> same change on review and Anthony nacked it on these grounds. >>>>> You could move the alias list to target-dependent code, though. >>>> >>>> Can't we just make the virtio-*-pci variants fail instantiation and based on that search the list on? >>> >>> No, but you could do: >> >> Ah, nice. Here is a fixed (and tested) version: > > Ping? What do we do about this one? Are you going to submit your fixed and tested version as a proper patch? You can add my SoB if you need to. Regards, Anthony Liguori > > > Alex >