From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:54949)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1SVNlM-0000i0-FT
	for qemu-devel@nongnu.org; Fri, 18 May 2012 10:02:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1SVNlI-0001r3-W1
	for qemu-devel@nongnu.org; Fri, 18 May 2012 10:02:35 -0400
Received: from mx1.redhat.com ([209.132.183.28]:14109)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1SVNlI-0001oM-Mx
	for qemu-devel@nongnu.org; Fri, 18 May 2012 10:02:32 -0400
Message-ID: <4FB656B2.2060803@redhat.com>
Date: Fri, 18 May 2012 16:03:30 +0200
From: Laszlo Ersek <lersek@redhat.com>
MIME-Version: 1.0
References: <1337265221-7136-1-git-send-email-lcapitulino@redhat.com>
	<1337265221-7136-5-git-send-email-lcapitulino@redhat.com>
In-Reply-To: <1337265221-7136-5-git-send-email-lcapitulino@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 04/16] qemu-option: parse_option_size():
	use error_set()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: pbonzini@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, armbru@redhat.com, mdroth@linux.vnet.ibm.com

On 05/17/12 16:33, Luiz Capitulino wrote:

> @@ -291,8 +290,10 @@ int set_option_parameter(QEMUOptionParameter *list, const char *name,
>          break;
>  
>      case OPT_SIZE:
> -        if (parse_option_size(name, value, &list->value.n) == -1)
> -            return -1;
> +        parse_option_size(name, value, &list->value.n, &local_err);
> +        if (error_is_set(&local_err)) {
> +            goto exit_err;
> +        }
>          break;
>  
>      default:
> @@ -602,7 +603,8 @@ static int qemu_opt_parse(QemuOpt *opt)
>                              &local_err);
>          break;
>      case QEMU_OPT_SIZE:
> -        return parse_option_size(opt->name, opt->str, &opt->value.uint);
> +        parse_option_size(opt->name, opt->str, &opt->value.uint, &local_err);
> +        break;
>      default:
>          abort();
>      }

... and then the set_option_parameter() change would look like the
qemu_opt_parse() change (no if or goto). But it's fine.

Laszlo