From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:54456)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1SVOn8-0003uQ-6c
	for qemu-devel@nongnu.org; Fri, 18 May 2012 11:08:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1SVOn6-0001Ej-Gs
	for qemu-devel@nongnu.org; Fri, 18 May 2012 11:08:29 -0400
Received: from mx1.redhat.com ([209.132.183.28]:4936)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1SVOn6-0001EZ-9E
	for qemu-devel@nongnu.org; Fri, 18 May 2012 11:08:28 -0400
Message-ID: <4FB66622.7000500@redhat.com>
Date: Fri, 18 May 2012 17:09:22 +0200
From: Laszlo Ersek <lersek@redhat.com>
MIME-Version: 1.0
References: <1337265221-7136-1-git-send-email-lcapitulino@redhat.com>
	<1337265221-7136-15-git-send-email-lcapitulino@redhat.com>
In-Reply-To: <1337265221-7136-15-git-send-email-lcapitulino@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 14/16] net: net_client_init(): use
	error_set()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: pbonzini@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, armbru@redhat.com, mdroth@linux.vnet.ibm.com

On 05/17/12 16:33, Luiz Capitulino wrote:
> @@ -1244,8 +1247,10 @@ int do_netdev_add(Monitor *mon, const QDict *qdict, QObject **ret_data)
>          return -1;
>      }
>  
> -    res = net_client_init(opts, 1);
> +    res = net_client_init(opts, 1, &local_err);
>      if (res < 0) {
> +        qerror_report_err(local_err);
> +        error_free(local_err);
>          qemu_opts_del(opts);
>      }
>  

I think this is the only net_client_init() caller hunk where we rely on
the retval instead of error_is_set(); but again, they seem to be
equivalent -- all branches in net_client_init() have been converted AFAICS.

(I can see that do_netdev_add() might set "local_err" higher up, and
then check "opts" again, instead of error_is_set(), but
qemu_opts_from_qdict() returns/sets those equivalently as well, so we
could use error_is_set() both times in do_netdev_add(), I think. Anyway,
it's OK.)

Laszlo