From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38367)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1SWRCm-0004fB-1W
	for qemu-devel@nongnu.org; Mon, 21 May 2012 07:55:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1SWRCf-0005R4-Pu
	for qemu-devel@nongnu.org; Mon, 21 May 2012 07:55:15 -0400
Received: from mx1.redhat.com ([209.132.183.28]:43753)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1SWRCf-0005Qh-HK
	for qemu-devel@nongnu.org; Mon, 21 May 2012 07:55:09 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4LBt7SH014856
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 21 May 2012 07:55:07 -0400
Received: from rincewind.home.kraxel.org (ovpn-116-43.ams2.redhat.com
	[10.36.116.43])
	by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP
	id q4LBt6Da025566
	for <qemu-devel@nongnu.org>; Mon, 21 May 2012 07:55:07 -0400
Message-ID: <4FBA2D18.9040706@redhat.com>
Date: Mon, 21 May 2012 13:55:04 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1337591088-18667-1-git-send-email-alevy@redhat.com>
	<1337591088-18667-2-git-send-email-alevy@redhat.com>
	<4FBA0948.60002@redhat.com> <20120521113514.GF5846@garlic>
In-Reply-To: <20120521113514.GF5846@garlic>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC 2/2] hmp/qxl: info spice: add qxl0_mode &
	qxl0_guest_bug
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

  Hi,

> OK, so I can fix this and remove the qxl0 hack at the same stroke. I was
> looking at using the system_bus, but that seems like another hack.

Didn't check what qom provides these days, searching for objects of a
certain type (for example a qxl device) should be possible IMO.  Dunno
whenever it actually is.

> The
> alternative is to keep a linked list of qxl devices private to qxl.c and
> use that, and the below functions become

Second best option if the QOM way doesn't fly.

> int qxl_guest_bug(int index)
> int qxl_mode(int index)
> int qxl_device_count(void)
> 
> How does that sound?

qxl_guest_bug(Object *dev) ?

cheers,
  Gerd