From: Paolo Bonzini <pbonzini@redhat.com>
To: aliguori@us.ibm.com
Cc: qemu-devel@nongnu.org, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1.1 0/4] decouple VIRTIO_BLK_F_SCSI from SG_IO support
Date: Mon, 21 May 2012 17:56:59 +0200 [thread overview]
Message-ID: <4FBA65CB.6080207@redhat.com> (raw)
In-Reply-To: <1337165646-28118-1-git-send-email-pbonzini@redhat.com>
Il 16/05/2012 12:54, Paolo Bonzini ha scritto:
> Previous versions of these patches have been posted already, but they
> were lost. Sorry for realizing this quite late.
>
> VIRTIO_BLK_F_SCSI is supposed to mean whether the host can *parse*
> SCSI requests, not *execute* them. So it should always be enabled,
> and the scsi=on/off property tied to a separate configuration variable
> that is not guest visible.
>
> With this change, Linux has problems understanding failed requests, so
> patch 1 works around the Linux bugs.
>
> Important: because we need to do this to fix a migration compatibility
> problem when QEMU might be invoked with an old machine type, we must do
> this unconditionally. This more or less assumes that no one ever invoked
> QEMU with scsi=off, as it breaks migration from new QEMU, scsi=off to
> old QEMU, also scsi=off. However new->old is not supported upstream.
>
> S390 compile-tested only.
>
> Paolo Bonzini (4):
> virtio-blk: report non-zero status when failing SG_IO requests
> virtio-blk: blockdev_mark_auto_del is transport-independent
> virtio-blk: define VirtIOBlkConf
> virtio-blk: always enable VIRTIO_BLK_F_SCSI
>
> hw/s390-virtio-bus.c | 10 ++++---
> hw/s390-virtio-bus.h | 4 +--
> hw/virtio-blk.c | 80 ++++++++++++++++++++++++--------------------------
> hw/virtio-blk.h | 14 +++++----
> hw/virtio-pci.c | 11 +++----
> hw/virtio-pci.h | 4 +--
> hw/virtio.h | 4 +--
> 7 files changed, 64 insertions(+), 63 deletions(-)
>
Ping?
next prev parent reply other threads:[~2012-05-21 15:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-16 10:54 [Qemu-devel] [PATCH 1.1 0/4] decouple VIRTIO_BLK_F_SCSI from SG_IO support Paolo Bonzini
2012-05-16 10:54 ` [Qemu-devel] [PATCH 1.1 1/4] virtio-blk: report non-zero status when failing SG_IO requests Paolo Bonzini
2012-05-16 10:54 ` [Qemu-devel] [PATCH 1.1 2/4] virtio-blk: blockdev_mark_auto_del is transport-independent Paolo Bonzini
2012-05-16 10:54 ` [Qemu-devel] [PATCH 1.1 3/4] virtio-blk: define VirtIOBlkConf Paolo Bonzini
2012-05-16 10:54 ` [Qemu-devel] [PATCH 1.1 4/4] virtio-blk: always enable VIRTIO_BLK_F_SCSI Paolo Bonzini
2012-05-21 15:56 ` Paolo Bonzini [this message]
2012-05-21 16:15 ` [Qemu-devel] [PATCH 1.1 0/4] decouple VIRTIO_BLK_F_SCSI from SG_IO support Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBA65CB.6080207@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).