From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45613) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWUyy-0002W9-38 for qemu-devel@nongnu.org; Mon, 21 May 2012 11:57:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SWUyr-0003nE-Rf for qemu-devel@nongnu.org; Mon, 21 May 2012 11:57:15 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:46107) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWUyr-0003mz-IS for qemu-devel@nongnu.org; Mon, 21 May 2012 11:57:09 -0400 Received: by pbbro12 with SMTP id ro12so8700261pbb.4 for ; Mon, 21 May 2012 08:57:06 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4FBA65CB.6080207@redhat.com> Date: Mon, 21 May 2012 17:56:59 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1337165646-28118-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1337165646-28118-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1.1 0/4] decouple VIRTIO_BLK_F_SCSI from SG_IO support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: aliguori@us.ibm.com Cc: qemu-devel@nongnu.org, mst@redhat.com Il 16/05/2012 12:54, Paolo Bonzini ha scritto: > Previous versions of these patches have been posted already, but they > were lost. Sorry for realizing this quite late. > > VIRTIO_BLK_F_SCSI is supposed to mean whether the host can *parse* > SCSI requests, not *execute* them. So it should always be enabled, > and the scsi=on/off property tied to a separate configuration variable > that is not guest visible. > > With this change, Linux has problems understanding failed requests, so > patch 1 works around the Linux bugs. > > Important: because we need to do this to fix a migration compatibility > problem when QEMU might be invoked with an old machine type, we must do > this unconditionally. This more or less assumes that no one ever invoked > QEMU with scsi=off, as it breaks migration from new QEMU, scsi=off to > old QEMU, also scsi=off. However new->old is not supported upstream. > > S390 compile-tested only. > > Paolo Bonzini (4): > virtio-blk: report non-zero status when failing SG_IO requests > virtio-blk: blockdev_mark_auto_del is transport-independent > virtio-blk: define VirtIOBlkConf > virtio-blk: always enable VIRTIO_BLK_F_SCSI > > hw/s390-virtio-bus.c | 10 ++++--- > hw/s390-virtio-bus.h | 4 +-- > hw/virtio-blk.c | 80 ++++++++++++++++++++++++-------------------------- > hw/virtio-blk.h | 14 +++++---- > hw/virtio-pci.c | 11 +++---- > hw/virtio-pci.h | 4 +-- > hw/virtio.h | 4 +-- > 7 files changed, 64 insertions(+), 63 deletions(-) > Ping?