From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57408) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWVH6-00032d-Lp for qemu-devel@nongnu.org; Mon, 21 May 2012 12:16:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SWVH1-0001V3-R3 for qemu-devel@nongnu.org; Mon, 21 May 2012 12:16:00 -0400 Received: from e38.co.us.ibm.com ([32.97.110.159]:50809) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWVH1-0001Nm-KX for qemu-devel@nongnu.org; Mon, 21 May 2012 12:15:55 -0400 Received: from /spool/local by e38.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 21 May 2012 10:15:51 -0600 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id 63E92C40005 for ; Mon, 21 May 2012 10:15:45 -0600 (MDT) Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q4LGFIw3041380 for ; Mon, 21 May 2012 10:15:30 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q4LGFHmt009592 for ; Mon, 21 May 2012 10:15:17 -0600 Message-ID: <4FBA6A13.8000301@us.ibm.com> Date: Mon, 21 May 2012 11:15:15 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1337165646-28118-1-git-send-email-pbonzini@redhat.com> <4FBA65CB.6080207@redhat.com> In-Reply-To: <4FBA65CB.6080207@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1.1 0/4] decouple VIRTIO_BLK_F_SCSI from SG_IO support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, mst@redhat.com On 05/21/2012 10:56 AM, Paolo Bonzini wrote: > Il 16/05/2012 12:54, Paolo Bonzini ha scritto: >> Previous versions of these patches have been posted already, but they >> were lost. Sorry for realizing this quite late. >> >> VIRTIO_BLK_F_SCSI is supposed to mean whether the host can *parse* >> SCSI requests, not *execute* them. So it should always be enabled, >> and the scsi=on/off property tied to a separate configuration variable >> that is not guest visible. >> >> With this change, Linux has problems understanding failed requests, so >> patch 1 works around the Linux bugs. >> >> Important: because we need to do this to fix a migration compatibility >> problem when QEMU might be invoked with an old machine type, we must do >> this unconditionally. This more or less assumes that no one ever invoked >> QEMU with scsi=off, as it breaks migration from new QEMU, scsi=off to >> old QEMU, also scsi=off. However new->old is not supported upstream. >> >> S390 compile-tested only. >> >> Paolo Bonzini (4): >> virtio-blk: report non-zero status when failing SG_IO requests >> virtio-blk: blockdev_mark_auto_del is transport-independent >> virtio-blk: define VirtIOBlkConf >> virtio-blk: always enable VIRTIO_BLK_F_SCSI >> >> hw/s390-virtio-bus.c | 10 ++++--- >> hw/s390-virtio-bus.h | 4 +-- >> hw/virtio-blk.c | 80 ++++++++++++++++++++++++-------------------------- >> hw/virtio-blk.h | 14 +++++---- >> hw/virtio-pci.c | 11 +++---- >> hw/virtio-pci.h | 4 +-- >> hw/virtio.h | 4 +-- >> 7 files changed, 64 insertions(+), 63 deletions(-) > > > Ping? Ack. I'll queue it for -rc3. Regards, Anthony Liguori >