From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50888) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWVWj-0007LH-9a for qemu-devel@nongnu.org; Mon, 21 May 2012 12:32:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SWVWg-0005t0-Eq for qemu-devel@nongnu.org; Mon, 21 May 2012 12:32:08 -0400 Message-ID: <4FBA6DFF.7070204@suse.de> Date: Mon, 21 May 2012 18:31:59 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1337616666-7503-1-git-send-email-chouteau@adacore.com> In-Reply-To: <1337616666-7503-1-git-send-email-chouteau@adacore.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH V2] booke_206_tlbwe: Discard invalid bits in MAS2 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fabien Chouteau , agraf@suse.de Cc: Blue Swirl , qemu-ppc@nongnu.org, qemu-devel@nongnu.org Am 21.05.2012 18:11, schrieb Fabien Chouteau: > The size of EPN field in MAS2 depends on page size. This patch adds a > mask to discard invalid bits in EPN field. >=20 > Definition of EPN field from e500v2 RM: > EPN Effective page number: Depending on page size, only the bits > associated with a page boundary are valid. Bits that represent offsets > within a page are ignored and should be cleared. >=20 > There is a similar (but more complicated) definition in PowerISA V2.06. >=20 > Signed-off-by: Fabien Chouteau > --- > target-ppc/op_helper.c | 17 +++++++++++++++-- > 1 file changed, 15 insertions(+), 2 deletions(-) >=20 > diff --git a/target-ppc/op_helper.c b/target-ppc/op_helper.c > index 4ef2332..481b51c 100644 > --- a/target-ppc/op_helper.c > +++ b/target-ppc/op_helper.c > @@ -4227,6 +4227,8 @@ void helper_booke206_tlbwe(void) > uint32_t tlbncfg, tlbn; > ppcmas_tlb_t *tlb; > uint32_t size_tlb, size_ps; > + target_ulong mask; > + > =20 > switch (env->spr[SPR_BOOKE_MAS0] & MAS0_WQ_MASK) { > case MAS0_WQ_ALWAYS: Minor nitpick: This adds a second white line. More severely, this patch is not marked as for 1.1 and I believe op_helper.c is dropped in Blue's AREG0 conversion, so I would recommend to rebase on that, since rebasing the large code movements was kind of nasty. Now that we've fixed ppc and ppc64 TCG it could be applied to ppc-next, no? Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg