From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39040) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWaSp-0004GA-PI for qemu-devel@nongnu.org; Mon, 21 May 2012 17:48:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SWaSo-0005QW-37 for qemu-devel@nongnu.org; Mon, 21 May 2012 17:48:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52431) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWaSn-0005QC-QM for qemu-devel@nongnu.org; Mon, 21 May 2012 17:48:26 -0400 Message-ID: <4FBAB81F.7080408@redhat.com> Date: Mon, 21 May 2012 15:48:15 -0600 From: Eric Blake MIME-Version: 1.0 References: <1337631598-30639-1-git-send-email-coreyb@linux.vnet.ibm.com> <1337631598-30639-3-git-send-email-coreyb@linux.vnet.ibm.com> In-Reply-To: <1337631598-30639-3-git-send-email-coreyb@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig6E67F50B3E5D0810EDF795B2" Subject: Re: [Qemu-devel] [RFC PATCH 2/4] qmp/hmp: Add getfd_file monitor command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Corey Bryant Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@linux.vnet.ibm.com, libvir-list@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig6E67F50B3E5D0810EDF795B2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/21/2012 02:19 PM, Corey Bryant wrote: > This patch provides support for the getfd_file monitor command. > This command will allow passing of a filename and its corresponding > file descriptor to a guest via the monitor. This command could be > followed, for example, by a drive_add command to hot attach a disk > drive. >=20 > Signed-off-by: Corey Bryant Is the only difference between 'getfd' and 'getfd_file' the fact that 'getfd' introduces an abstract namespace usable only by the fd: protocol, while the 'getfd_file' introduces a name identical to the absolute naming of the file system and usable by the file: protocol? What happens if I pass 'getfd_file' a relative file name? Must the filename passed to 'getfd_file' be in canonical form, or may it contain symlinks, .., and other non-canonical constructs? Can the 'closefd' command be used to close the fd originally given to qemu via 'getfd_file'? --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig6E67F50B3E5D0810EDF795B2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJPurgfAAoJEKeha0olJ0NqoTQH/3Z6xtVFnyTiJ5zFMKJ8TZoO WPiMd5gg950Q41HtIZQszb4lU1ZUg3Enj9yxmrx2WbUYdcSB07mUcFvkabRu+zDm HU1BZuuj6Kuw98YOkGu31Yr2kxZ48HfO2phpF+gwUuul0yizMzZIztySh3iry1RL Rpzgje+osbwBiZMaWrPDxHjMSkeMZvBT1+50owEBW3jcW6+pZvxqD1x8T0st0UC7 JI+GmVxz8GwhjFLlmLXFgy0SVAYEItcUvuCf1EjbMocOW+jb0E06LbPwi/3S8VOC wL9HBBGEEeEwOLs+/kDyKPEK6Rvwoe94EpAY8GFL8THJzC+EMGnsK5xtqJmhaY8= =F8gp -----END PGP SIGNATURE----- --------------enig6E67F50B3E5D0810EDF795B2--