qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: 'dunrong huang' <riegamaths@gmail.com>,
	Anthony Liguori <anthony@codemonkey.ws>,
	Pavel Dovgaluk <Pavel.Dovgaluk@ispras.ru>,
	'qemu-devel' <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] Prevent disk data loss when closing qemu
Date: Tue, 22 May 2012 11:25:20 +0200	[thread overview]
Message-ID: <4FBB5B80.20409@redhat.com> (raw)
In-Reply-To: <4FBB5396.2010001@redhat.com>

Il 22/05/2012 10:51, Kevin Wolf ha scritto:
> Am 16.05.2012 12:16, schrieb Pavel Dovgaluk:
>> I use qemu under Windows and it has two windows when executes - console and SDL ones.
>> When I close SDL window main loop function terminates correctly, and when I close 
>> console window to terminate qemu then the code after main loop is not executed.
> 
> Is there no way to catch this case and use the regular shutdown
> mechanism there as well?
> 
> I'm not against your patch and it's probably 1.1 material, but there may
> be more shutdown logic that we're missing if you close the console window.

Looks like qemu_ctrl_handler (in os-win32.c) needs to do something like
termsig_handler (in os-posix.c) instead of a plain exit.

Paolo

  reply	other threads:[~2012-05-22  9:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4fb35a7e.2458b40a.3ed6.649cSMTPIN_ADDED@mx.google.com>
2012-05-16  8:16 ` [Qemu-devel] [PATCH] Prevent disk data loss when closing qemu dunrong huang
2012-05-16 10:16   ` Pavel Dovgaluk
2012-05-22  8:51     ` Kevin Wolf
2012-05-22  9:25       ` Paolo Bonzini [this message]
2012-05-23  6:48         ` Pavel Dovgaluk
     [not found]         ` <3123.31610261953$1337755763@news.gmane.org>
2012-05-23  7:03           ` Paolo Bonzini
2012-05-24  7:41             ` Pavel Dovgaluk
2012-05-16  7:42 Pavel Dovgaluk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FBB5B80.20409@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=Pavel.Dovgaluk@ispras.ru \
    --cc=anthony@codemonkey.ws \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=riegamaths@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).