From: Kevin Wolf <kwolf@redhat.com>
To: Jim Meyering <jim@meyering.net>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/3] envlist.c: handle strdup failure
Date: Tue, 22 May 2012 11:34:34 +0200 [thread overview]
Message-ID: <4FBB5DAA.3@redhat.com> (raw)
In-Reply-To: <87hav8k2ks.fsf@rho.meyering.net>
Am 22.05.2012 11:05, schrieb Jim Meyering:
> Kevin Wolf wrote:
>> A patch replacing tabs by spaces isn't really the kind of patches that
>> we would want to avoid during freeze. It's easy enough to check with git
>> diff -w that it doesn't change anything semantically.
>
> That makes sense, so I've posted two patches:
>
> 1) two patches: one replacing all leading TABs with equivalent spaces,
> then the above patch
>
> Note however, that envlist.c must predate checkpatch.pl, since
> that patch provokes numerous warnings about style issues:
Quite possible. Most files in qemu will still contain some violations.
> (hmm... I've just noticed these first two, which seem to suggest
> that even for comments I should remove the TABs. Is it worth
> a V2 to fix those two lines? Or are they false positives, since
> they're not really "code" indentation? )
We don't use tabs at all where possible. There shouldn't be much more
exceptions than the Makefiles.
Kevin
next prev parent reply other threads:[~2012-05-22 9:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 13:04 [Qemu-devel] [PATCH 0/3] unchecked uses of strdup jim
2012-05-15 13:04 ` [Qemu-devel] [PATCH 1/3] envlist.c: handle strdup failure jim
2012-05-19 15:55 ` Blue Swirl
2012-05-21 10:25 ` Jim Meyering
2012-05-21 17:56 ` Blue Swirl
2012-05-22 8:23 ` Kevin Wolf
2012-05-22 9:05 ` Jim Meyering
2012-05-22 9:34 ` Kevin Wolf [this message]
2012-05-22 9:50 ` Jim Meyering
2012-05-15 13:04 ` [Qemu-devel] [PATCH 2/3] scsi, pci, qdev, isa-bus, sysbus: don't let *_get_fw_dev_path return NULL jim
2012-05-15 13:13 ` Paolo Bonzini
2012-05-15 13:35 ` Kevin Wolf
2012-05-15 13:04 ` [Qemu-devel] [PATCH 3/3] sparc: use g_strdup in place of unchecked strdup jim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBB5DAA.3@redhat.com \
--to=kwolf@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=jim@meyering.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).