From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:35328)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1SWlUN-0004nv-Qx
	for qemu-devel@nongnu.org; Tue, 22 May 2012 05:34:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1SWlUM-0003Kg-2W
	for qemu-devel@nongnu.org; Tue, 22 May 2012 05:34:47 -0400
Received: from mx1.redhat.com ([209.132.183.28]:4599)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1SWlUL-0003KP-Qg
	for qemu-devel@nongnu.org; Tue, 22 May 2012 05:34:45 -0400
Message-ID: <4FBB5DAA.3@redhat.com>
Date: Tue, 22 May 2012 11:34:34 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1337087078-24056-1-git-send-email-jim@meyering.net>
	<1337087078-24056-2-git-send-email-jim@meyering.net>
	<CAAu8pHs0CegL1=Eojw-_r=-LUgK_HVbH4YtMZ-RCyuJqJ15GPA@mail.gmail.com>
	<87wr45n84r.fsf@rho.meyering.net>
	<CAAu8pHvrDCax++p4W0yJ+OumcaGMRo+7d4xPdqs-xop7SXcgJg@mail.gmail.com>
	<4FBB4CEE.8040103@redhat.com> <87hav8k2ks.fsf@rho.meyering.net>
In-Reply-To: <87hav8k2ks.fsf@rho.meyering.net>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/3] envlist.c: handle strdup failure
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jim Meyering <jim@meyering.net>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org

Am 22.05.2012 11:05, schrieb Jim Meyering:
> Kevin Wolf wrote:
>> A patch replacing tabs by spaces isn't really the kind of patches that
>> we would want to avoid during freeze. It's easy enough to check with git
>> diff -w that it doesn't change anything semantically.
> 
> That makes sense, so I've posted two patches:
> 
>     1) two patches: one replacing all leading TABs with equivalent spaces,
>           then the above patch
> 
> Note however, that envlist.c must predate checkpatch.pl, since
> that patch provokes numerous warnings about style issues:

Quite possible. Most files in qemu will still contain some violations.

> (hmm... I've just noticed these first two, which seem to suggest
> that even for comments I should remove the TABs.  Is it worth
> a V2 to fix those two lines?  Or are they false positives, since
> they're not really "code" indentation?  )

We don't use tabs at all where possible. There shouldn't be much more
exceptions than the Makefiles.

Kevin