From: Igor Mammedov <imammedo@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: aliguori@us.ibm.com, ehabkost@redhat.com, sw@weilnetz.de,
mtosatti@redhat.com, qemu-devel@nongnu.org, blauwirbel@gmail.com,
avi@redhat.com, jan.kiszka@siemens.com, pbonzini@redhat.com,
afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH qom-next 1/5] target-i386: move cpu halted decision into x86_cpu_reset
Date: Tue, 22 May 2012 14:34:30 +0200 [thread overview]
Message-ID: <4FBB87D6.4030302@redhat.com> (raw)
In-Reply-To: <CAFEAcA-tjR=uC+zF2jat4UqzO-ehFCBeGfssOQarph0igMXX1g@mail.gmail.com>
On 05/22/2012 12:59 PM, Peter Maydell wrote:
> On 22 May 2012 11:35, Igor Mammedov<imammedo@redhat.com> wrote:
>> From: Igor Mammedov<niallain@gmail.com>
>>
>> MP initialization protocol differs between cpu families, and for P6 and
>> onward models it is up to CPU to decide if it will be BSP using this
>> protocol, so try to model this. However there is no point in implementing
>> MP initialization protocol in qemu. Thus first CPU is always marked as BSP.
>
> This breaks compilation of the i386-linux-user target:
> target-i386/cpu.c: In function ‘x86_cpu_reset’:
> target-i386/cpu.c:1710: error: implicit declaration of function
> ‘apic_designate_bsp’
> target-i386/cpu.c:1710: error: nested extern declaration of ‘apic_designate_bsp’
> target-i386/cpu.c:1713: error: implicit declaration of function
> ‘cpu_get_apic_base’
> target-i386/cpu.c:1713: error: nested extern declaration of ‘cpu_get_apic_base’
>
> -- PMM
>
I'm sorry for forgetting about testing -user target, I'll fix it and repost.
--
-----
Thanks,
Igor
next prev parent reply other threads:[~2012-05-22 12:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-22 10:35 [Qemu-devel] [PATCH qom-next 0/5] target-i386: re-factor CPU creation/initialization to QOM Igor Mammedov
2012-05-22 10:35 ` [Qemu-devel] [PATCH qom-next 1/5] target-i386: move cpu halted decision into x86_cpu_reset Igor Mammedov
2012-05-22 10:59 ` Peter Maydell
2012-05-22 12:34 ` Igor Mammedov [this message]
2012-05-22 10:35 ` [Qemu-devel] [PATCH qom-next 2/5] target-i386: add cpu-model property to x86_cpu Igor Mammedov
2012-05-22 10:35 ` [Qemu-devel] [PATCH qom-next 3/5] pc: move apic_mapped initialization into common apic init code Igor Mammedov
2012-05-22 10:48 ` Jan Kiszka
2012-05-22 12:42 ` Igor Mammedov
2012-05-22 14:24 ` Andreas Färber
2012-05-22 14:35 ` Jan Kiszka
2012-05-22 15:47 ` Paolo Bonzini
2012-05-23 9:17 ` Igor Mammedov
2012-05-22 10:51 ` Jan Kiszka
2012-05-22 10:35 ` [Qemu-devel] [PATCH qom-next 4/5] target-i386: make initialize CPU in QOM way Igor Mammedov
2012-05-22 10:56 ` Jan Kiszka
2012-05-22 12:47 ` Igor Mammedov
2012-05-22 10:35 ` [Qemu-devel] [PATCH qom-next 5/5] target-i386: move reset callback to cpu.c Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBB87D6.4030302@redhat.com \
--to=imammedo@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=ehabkost@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).