From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41411) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWoJA-0007U0-DF for qemu-devel@nongnu.org; Tue, 22 May 2012 08:35:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SWoIP-000868-0J for qemu-devel@nongnu.org; Tue, 22 May 2012 08:35:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41944) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWoIO-00085u-Oz for qemu-devel@nongnu.org; Tue, 22 May 2012 08:34:36 -0400 Message-ID: <4FBB87D6.4030302@redhat.com> Date: Tue, 22 May 2012 14:34:30 +0200 From: Igor Mammedov MIME-Version: 1.0 References: <1337682954-20618-1-git-send-email-imammedo@redhat.com> <1337682954-20618-2-git-send-email-imammedo@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH qom-next 1/5] target-i386: move cpu halted decision into x86_cpu_reset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: aliguori@us.ibm.com, ehabkost@redhat.com, sw@weilnetz.de, mtosatti@redhat.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, avi@redhat.com, jan.kiszka@siemens.com, pbonzini@redhat.com, afaerber@suse.de On 05/22/2012 12:59 PM, Peter Maydell wrote: > On 22 May 2012 11:35, Igor Mammedov wrote: >> From: Igor Mammedov >> >> MP initialization protocol differs between cpu families, and for P6 an= d >> onward models it is up to CPU to decide if it will be BSP using this >> protocol, so try to model this. However there is no point in implement= ing >> MP initialization protocol in qemu. Thus first CPU is always marked as= BSP. > > This breaks compilation of the i386-linux-user target: > target-i386/cpu.c: In function =E2=80=98x86_cpu_reset=E2=80=99: > target-i386/cpu.c:1710: error: implicit declaration of function > =E2=80=98apic_designate_bsp=E2=80=99 > target-i386/cpu.c:1710: error: nested extern declaration of =E2=80=98ap= ic_designate_bsp=E2=80=99 > target-i386/cpu.c:1713: error: implicit declaration of function > =E2=80=98cpu_get_apic_base=E2=80=99 > target-i386/cpu.c:1713: error: nested extern declaration of =E2=80=98cp= u_get_apic_base=E2=80=99 > > -- PMM > I'm sorry for forgetting about testing -user target, I'll fix it and repo= st. --=20 ----- Thanks, Igor