From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57934) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWopa-0006GC-4b for qemu-devel@nongnu.org; Tue, 22 May 2012 09:08:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SWopT-0005Y8-KG for qemu-devel@nongnu.org; Tue, 22 May 2012 09:08:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48370) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWopT-0005Xm-C5 for qemu-devel@nongnu.org; Tue, 22 May 2012 09:08:47 -0400 Message-ID: <4FBB8FD1.4080602@redhat.com> Date: Tue, 22 May 2012 07:08:33 -0600 From: Eric Blake MIME-Version: 1.0 References: <1337691425-6022-1-git-send-email-owasserm@redhat.com> <1337691425-6022-3-git-send-email-owasserm@redhat.com> In-Reply-To: <1337691425-6022-3-git-send-email-owasserm@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig8E9FD9EEBF2DBE61BCBCCC0D" Subject: Re: [Qemu-devel] [PATCH v11 2/9] Add migration capabilites List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Orit Wasserman Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, quintela@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, avi@redhat.com, pbonzini@redhat.com, chegu_vinod@hp.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig8E9FD9EEBF2DBE61BCBCCC0D Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/22/2012 06:56 AM, Orit Wasserman wrote: > Add migration capabiltes that can be queried by the management. > The managment can query the source QEMU and the destination QEMU in ord= er to > verify both support some migration capability (currently only XBZRLE).= > The managment can enable a capabilty for the next migration by using > migrate_set_parameter command. >=20 > ## > +# @MigrationCapability > +# > +# Migration capabilities enumaration > +# > +# @xbzrle: current migration supports xbzrle > +# > +# Since: 1.1 1.2 > +## > +{ 'enum': 'MigrationCapability', > + 'data': ['xbzrle'] } > + > + > +## > +# @migrate_set_parameter > +# > +# Set the following migration parameters (like xbzrle ) > +## > +# Since: 1.2 > +## > +{ 'command': 'migrate-set-parameter', 'data': { 'parameter': 'str' } }= This requires libvirt to issue multiple monitor commands in a row. Also, it's pretty poorly typed. It might be nicer to provide: { 'command': 'migrate-set-parameters', 'data': { 'parameters': ['MigrationCapability'] } } so that I can set multiple parameters in one call. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig8E9FD9EEBF2DBE61BCBCCC0D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJPu4/RAAoJEKeha0olJ0NqgBwIAK+UsRtS90b3U4M0slJh94fM l0bRhNxnyhREdxxoj4EpsMogKg4yDq5wqcmMp88o6iUq0jeSW6ZLgPdvddhXnlQw v2cP87hZq5Yh5EZiOEPok7yJ0zvlGoMQllP86RkmO8dg+VMi9kUgSGRGPPQpgAyK 6sWw+/Ics8Rkx0tBROYCxEGvJ/XxnRaT9U1BTcPf7+1WnqZ9wGIp1JmRgU3kupia EI3SbC1Fn8jqo99sVS7f4GXIqsM8nan0LuMC3FP2AmBasH8hYOd07szCWe6dHMar dPl4QjJqpm0W2uENPqfMvvujzQKHizu4A/7CU0KbJKyPkk1jPcw6YvI8MrmUOhA= =ZaRr -----END PGP SIGNATURE----- --------------enig8E9FD9EEBF2DBE61BCBCCC0D--