From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59068) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWp8f-000558-3K for qemu-devel@nongnu.org; Tue, 22 May 2012 09:28:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SWp8T-0003eR-Hn for qemu-devel@nongnu.org; Tue, 22 May 2012 09:28:36 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:45066) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWp8T-0003d8-BZ for qemu-devel@nongnu.org; Tue, 22 May 2012 09:28:25 -0400 Received: from /spool/local by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 22 May 2012 07:28:21 -0600 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id EA6A0C40002 for ; Tue, 22 May 2012 07:28:03 -0600 (MDT) Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q4MDROvB166080 for ; Tue, 22 May 2012 07:27:41 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q4MDR7Es014026 for ; Tue, 22 May 2012 07:27:07 -0600 Message-ID: <4FBB93BC.9080901@linux.vnet.ibm.com> Date: Tue, 22 May 2012 09:25:16 -0400 From: Corey Bryant MIME-Version: 1.0 References: <1337631598-30639-1-git-send-email-coreyb@linux.vnet.ibm.com> <1337631598-30639-2-git-send-email-coreyb@linux.vnet.ibm.com> <4FBAB641.20109@redhat.com> In-Reply-To: <4FBAB641.20109@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 1/4] qemu-options: Add -filefd command line option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, libvir-list@redhat.com, aliguori@us.ibm.com, stefanha@linux.vnet.ibm.com, qemu-devel@nongnu.org On 05/21/2012 05:40 PM, Eric Blake wrote: > On 05/21/2012 02:19 PM, Corey Bryant wrote: >> This patch provides support for the -filefd command line option. >> This option will allow passing of a filename and its corresponding >> file descriptor to QEMU at exec time. >> >> Signed-off-by: Corey Bryant > >> +DEF("filefd", HAS_ARG, QEMU_OPTION_filefd, >> + "-filefd file=,fd=\n" > > I take it that if filename contains ',', then we have to escape it on > the command line? Is it worth passing fd first and file second by > default, as a possible way to avoid the need for escaping, or does the > option parser not care about ordering? > That's a good question. The options can be ordered either way so I don't think we'll force fd to be specified first. I imagine this should behave no differently than "-drive file=xyz,if=none,...". I ran a quick test using -drive with a filename that had a comma, and (escaped or not) it failed on the option parsing. So it looks like if you have a path with a comma you're not going to have any luck. -- Regards, Corey