From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48513) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWpJA-0001Vw-MA for qemu-devel@nongnu.org; Tue, 22 May 2012 09:39:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SWpJ4-0006bF-AC for qemu-devel@nongnu.org; Tue, 22 May 2012 09:39:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54020) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWpJ4-0006av-2E for qemu-devel@nongnu.org; Tue, 22 May 2012 09:39:22 -0400 Message-ID: <4FBB96CA.3010500@redhat.com> Date: Tue, 22 May 2012 15:38:18 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1337631598-30639-1-git-send-email-coreyb@linux.vnet.ibm.com> <1337631598-30639-2-git-send-email-coreyb@linux.vnet.ibm.com> <4FBAB641.20109@redhat.com> <4FBB93BC.9080901@linux.vnet.ibm.com> In-Reply-To: <4FBB93BC.9080901@linux.vnet.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 1/4] qemu-options: Add -filefd command line option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Corey Bryant Cc: libvir-list@redhat.com, aliguori@us.ibm.com, Eric Blake , stefanha@linux.vnet.ibm.com, qemu-devel@nongnu.org Am 22.05.2012 15:25, schrieb Corey Bryant: > > > On 05/21/2012 05:40 PM, Eric Blake wrote: >> On 05/21/2012 02:19 PM, Corey Bryant wrote: >>> This patch provides support for the -filefd command line option. >>> This option will allow passing of a filename and its corresponding >>> file descriptor to QEMU at exec time. >>> >>> Signed-off-by: Corey Bryant >> >>> +DEF("filefd", HAS_ARG, QEMU_OPTION_filefd, >>> + "-filefd file=,fd=\n" >> >> I take it that if filename contains ',', then we have to escape it on >> the command line? Is it worth passing fd first and file second by >> default, as a possible way to avoid the need for escaping, or does the >> option parser not care about ordering? >> > > That's a good question. The options can be ordered either way so I > don't think we'll force fd to be specified first. I imagine this should > behave no differently than "-drive file=xyz,if=none,...". I ran a quick > test using -drive with a filename that had a comma, and (escaped or not) > it failed on the option parsing. So it looks like if you have a path > with a comma you're not going to have any luck. I think you can escape it, you'd have to use a double comma. But I'd rather not introduce more of this. It's another good reason for using /dev/fd/... instead of a translation table. Kevin