From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48087) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWsmP-0003Lp-ML for qemu-devel@nongnu.org; Tue, 22 May 2012 13:21:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SWsmN-0004Bj-Ol for qemu-devel@nongnu.org; Tue, 22 May 2012 13:21:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49925) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWsmN-0004Bc-G6 for qemu-devel@nongnu.org; Tue, 22 May 2012 13:21:51 -0400 Message-ID: <4FBBCB28.1020103@redhat.com> Date: Tue, 22 May 2012 11:21:44 -0600 From: Eric Blake MIME-Version: 1.0 References: <1337707197-3822-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1337707197-3822-1-git-send-email-peter.maydell@linaro.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig8367FFB697E59839A1F3817D" Subject: Re: [Qemu-devel] [PATCH v2] hw/a9mpcore: Fix compilation failure if physaddrs are 64 bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Paul Brook , qemu-devel@nongnu.org, patches@linaro.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig8367FFB697E59839A1F3817D Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/22/2012 11:19 AM, Peter Maydell wrote: > Add a cast to a logging printf to avoid a compilation failure > if target_phys_addr_t is a 64 bit type. (This is better than > using TARGET_FMT_plx because we really don't need a full > 16 digit hex string to print the offset into a device.) >=20 > Signed-off-by: Peter Maydell > --- > v1->v2: cast to unsigned int, not uint32_t. >=20 > hw/a9mpcore.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) >=20 > diff --git a/hw/a9mpcore.c b/hw/a9mpcore.c > index c2ff74d..ebd5b29 100644 > --- a/hw/a9mpcore.c > +++ b/hw/a9mpcore.c > @@ -75,7 +75,7 @@ static void a9_scu_write(void *opaque, target_phys_ad= dr_t offset, > break; > default: > fprintf(stderr, "Invalid size %u in write to a9 scu register %= x\n", > - size, offset); > + size, (unsigned)offset); Reviewed-by: Eric Blake --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig8367FFB697E59839A1F3817D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJPu8soAAoJEKeha0olJ0NqtAAH/jd708Gd5hggbsngglYk4u3I mK6A6C1ptJf6ejW7J3Pzngg7nXL66ZVtVDaBtEJRaEYXg0dTvxvfr429W6PNapXF 9ND+zoFAzp6ad9he8ZR6N29U/bCs+2HULED/nOZg0uY32A+xqsbGcxI77+A0T1m7 GdRR+aC5hzXNqUHtoWs2JZwLz44HKv4jPC40gkg1EwVbpkFcDp/a7NZ+WsEY6UpT Vf9R05Fw3ScYCSZgvo/mVC5OIhkLtq/3M72F60GmG+nmlxM6Ox5fXRAho4WcEsor TzLjBibEcUb/wO4ede3V8Q7GW6ra9HmORFkD+KTsRmCUyDtXxuhLK2AZEX84jP4= =NCP0 -----END PGP SIGNATURE----- --------------enig8367FFB697E59839A1F3817D--