From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59674) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWvIQ-0003Yf-60 for qemu-devel@nongnu.org; Tue, 22 May 2012 16:03:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SWvIO-0007yH-7j for qemu-devel@nongnu.org; Tue, 22 May 2012 16:03:05 -0400 Received: from e9.ny.us.ibm.com ([32.97.182.139]:35279) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWvIO-0007x8-3U for qemu-devel@nongnu.org; Tue, 22 May 2012 16:03:04 -0400 Received: from /spool/local by e9.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 22 May 2012 16:02:56 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 6578338C806D for ; Tue, 22 May 2012 16:02:49 -0400 (EDT) Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q4MK2igG125112 for ; Tue, 22 May 2012 16:02:45 -0400 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q4MK2fPp007850 for ; Tue, 22 May 2012 14:02:44 -0600 Message-ID: <4FBBF0CB.6070404@linux.vnet.ibm.com> Date: Tue, 22 May 2012 16:02:19 -0400 From: Corey Bryant MIME-Version: 1.0 References: <1337631598-30639-1-git-send-email-coreyb@linux.vnet.ibm.com> <1337631598-30639-3-git-send-email-coreyb@linux.vnet.ibm.com> <20120522160606.05b3fb96@doriath.home> In-Reply-To: <20120522160606.05b3fb96@doriath.home> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 2/4] qmp/hmp: Add getfd_file monitor command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@linux.vnet.ibm.com, libvir-list@redhat.com, Stefan Hajnoczi , qemu-devel@nongnu.org, eblake@redhat.com On 05/22/2012 03:06 PM, Luiz Capitulino wrote: > On Tue, 22 May 2012 10:18:22 +0100 > Stefan Hajnoczi wrote: > >> QMP commands should be added to qapi-schema.json as described in >> docs/writing-qmp-commands.txt. > > Looks like there's consensus on dropping this patch and enhancing getfd > to return the fd number. This would require to first convert getfd from > plain HMP to the QAPI, which is basically to say more or less the same > thing as Stefan said above (you could also look for examples searching > for "qapi: convert" in the git log). Yep, ok thanks. > > But there's a small problem. Today getfd commands are closely tied to the > Monitor. In Anthony's development tree, the getfd commands are tied to the > new QMP server's session support. > > Asking you to integrate the new QMP server only to have the getfd command > returning a simple integer would be too much, but at the same time I think > you'll have to at least to break it from the monitor. This means moving its > data structure away from the Monitor object and probably reworking the > internal API used to get fds (ie. monitor_get_fd()). > > Shouldn't be hard, but you should be careful not to break external users. > Just to verify, are you talking about moving the "fds" off the Monitor struct? --> QLIST_HEAD(,mon_fd_t) fds; Was this already moved away from the Monitor struct in Anthony's development tree? If not do you have a recommendation on where to move it? I think this would make more sense to me if I took a look at the getfd code in Anthony's development tree. Is this the correct tree? I had some issues cloning it. https://github.com/aliguori/qemu-next.git -- Regards, Corey