From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46523) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWxfo-0003m6-7P for qemu-devel@nongnu.org; Tue, 22 May 2012 18:35:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SWxfm-0006Mk-A5 for qemu-devel@nongnu.org; Tue, 22 May 2012 18:35:23 -0400 Received: from e6.ny.us.ibm.com ([32.97.182.146]:39695) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWxfm-0006L3-56 for qemu-devel@nongnu.org; Tue, 22 May 2012 18:35:22 -0400 Received: from /spool/local by e6.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 22 May 2012 18:35:12 -0400 Received: from d01relay07.pok.ibm.com (d01relay07.pok.ibm.com [9.56.227.147]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 555ED38C805F for ; Tue, 22 May 2012 18:34:21 -0400 (EDT) Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay07.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q4MMYLkk19529834 for ; Tue, 22 May 2012 18:34:21 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q4N45DuW011415 for ; Wed, 23 May 2012 00:05:13 -0400 Message-ID: <4FBC146B.6050801@linux.vnet.ibm.com> Date: Tue, 22 May 2012 18:34:19 -0400 From: Corey Bryant MIME-Version: 1.0 References: <1337631598-30639-1-git-send-email-coreyb@linux.vnet.ibm.com> <1337631598-30639-3-git-send-email-coreyb@linux.vnet.ibm.com> <20120522160606.05b3fb96@doriath.home> <4FBBF0CB.6070404@linux.vnet.ibm.com> <20120522172646.006012f2@doriath.home> In-Reply-To: <20120522172646.006012f2@doriath.home> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 2/4] qmp/hmp: Add getfd_file monitor command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@linux.vnet.ibm.com, libvir-list@redhat.com, Stefan Hajnoczi , qemu-devel@nongnu.org, eblake@redhat.com On 05/22/2012 04:26 PM, Luiz Capitulino wrote: > On Tue, 22 May 2012 16:02:19 -0400 > Corey Bryant wrote: > >>> But there's a small problem. Today getfd commands are closely tied to the >>> Monitor. In Anthony's development tree, the getfd commands are tied to the >>> new QMP server's session support. >>> >>> Asking you to integrate the new QMP server only to have the getfd command >>> returning a simple integer would be too much, but at the same time I think >>> you'll have to at least to break it from the monitor. This means moving its >>> data structure away from the Monitor object and probably reworking the >>> internal API used to get fds (ie. monitor_get_fd()). >>> >>> Shouldn't be hard, but you should be careful not to break external users. >>> >> >> Just to verify, are you talking about moving the "fds" off the Monitor >> struct? --> QLIST_HEAD(,mon_fd_t) fds; > > Yes. > >> Was this already moved away from the Monitor struct in Anthony's >> development tree? If not do you have a recommendation on where to move it? > > Yes, iirc it moved inside the new QMP server session support in Anthony's tree. > >> I think this would make more sense to me if I took a look at the getfd >> code in Anthony's development tree. Is this the correct tree? I had >> some issues cloning it. https://github.com/aliguori/qemu-next.git > > The 'development' tree I'm referring to is the old glib branch in > git://repo.or.cz/qemu/aliguori.git. > Hmm, it looks like fds is still on the Monitor struct in that branch. I'll do some more searching later unless you have anything else you can point me to. -- Regards, Corey