From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36935)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1SX7qO-0007J5-RJ
	for qemu-devel@nongnu.org; Wed, 23 May 2012 05:27:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1SX7qI-0007pw-L2
	for qemu-devel@nongnu.org; Wed, 23 May 2012 05:27:00 -0400
Received: from mx1.redhat.com ([209.132.183.28]:32936)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1SX7qI-0007pb-DK
	for qemu-devel@nongnu.org; Wed, 23 May 2012 05:26:54 -0400
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4N9QqFH026369
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 23 May 2012 05:26:52 -0400
Message-ID: <4FBCAD5A.1040702@redhat.com>
Date: Wed, 23 May 2012 11:26:50 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <cover.1337698475.git.phrdina@redhat.com>
	<a13f58fd1dfba3064819428420375725aaa5c160.1337698475.git.phrdina@redhat.com>
	<4FBCA210.60801@redhat.com> <m3txz7w96y.fsf@blackfin.pond.sub.org>
In-Reply-To: <m3txz7w96y.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 1/2] fdc: floppy drive should be visible
 after start without media
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Pavel Hrdina <phrdina@redhat.com>, qemu-devel@nongnu.org

Am 23.05.2012 11:14, schrieb Markus Armbruster:
> Kevin Wolf <kwolf@redhat.com> writes:
> 
>> Am 22.05.2012 17:00, schrieb Pavel Hrdina:
>>> If you start guest with floppy drive but without media inserted, guest
>>> still should see floppy drive pressent.
>>>
>>> Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
>>> ---
>>>  hw/pc.c |    2 +-
>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/hw/pc.c b/hw/pc.c
>>> index 4d34a33..967c17a 100644
>>> --- a/hw/pc.c
>>> +++ b/hw/pc.c
>>> @@ -382,7 +382,7 @@ void pc_cmos_init(ram_addr_t ram_size, ram_addr_t above_4g_mem_size,
>>>      if (floppy) {
>>>          fdc_get_bs(fd, floppy);
>>>          for (i = 0; i < 2; i++) {
>>> -            if (fd[i] && bdrv_is_inserted(fd[i])) {
>>> +            if (fd[i]) {
>>>                  bdrv_get_floppy_geometry_hint(fd[i], &nb_heads, &max_track,
>>>                                                &last_sect, FDRIVE_DRV_NONE,
>>>                                                &fd_type[i], &rate);
>>
>> I'm not completely sure, but we might have to make this change dependent
>> on the machine type to avoid surprises with live migration.
> 
> What kind of surprises do you have in mind?

A second drive appearing (or appearing in part) after a migration. But
looking closer at the code, this really only changes the CMOS (which is
migrated) and doesn't seem to have any side effects.

Kevin