From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35456) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXAmr-0006cH-NG for qemu-devel@nongnu.org; Wed, 23 May 2012 08:35:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXAmh-0001Od-Q5 for qemu-devel@nongnu.org; Wed, 23 May 2012 08:35:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46993) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXAmh-0001OG-I0 for qemu-devel@nongnu.org; Wed, 23 May 2012 08:35:23 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4NCZLnb005986 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 23 May 2012 08:35:22 -0400 Message-ID: <4FBCD987.9070100@redhat.com> Date: Wed, 23 May 2012 14:35:19 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <4FBCD4CB.2090203@redhat.com> In-Reply-To: <4FBCD4CB.2090203@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 3/3] fdc-test: introduced qtest no_media_on_start List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Pavel Hrdina , qemu-devel@nongnu.org, armbru@redhat.com Am 23.05.2012 14:15, schrieb Paolo Bonzini: > Il 23/05/2012 13:27, Pavel Hrdina ha scritto: >> After guest start DSKCHG bit in DIR register should be set. If there >> is no media in drive, this bit should be set all the time. >> >> Signed-off-by: Pavel Hrdina >> --- >> tests/fdc-test.c | 29 ++++++++++++++++++++++++++--- >> 1 files changed, 26 insertions(+), 3 deletions(-) >> >> diff --git a/tests/fdc-test.c b/tests/fdc-test.c >> index 5b5dd74..e002c5c 100644 >> --- a/tests/fdc-test.c >> +++ b/tests/fdc-test.c >> @@ -108,6 +108,30 @@ static void send_step_pulse(void) >> cyl = (cyl + 1) % 4; >> } >> >> +static void test_no_media_on_start(void) >> +{ >> + uint8_t dir; >> + >> + /* Media changed bit must be set all time after start if there is >> + * no media in drive. */ >> + dir = inb(FLOPPY_BASE + reg_dir); >> + assert_bit_set(dir, DSKCHG); >> + dir = inb(FLOPPY_BASE + reg_dir); >> + assert_bit_set(dir, DSKCHG); >> + send_step_pulse(); >> + send_step_pulse(); >> + dir = inb(FLOPPY_BASE + reg_dir); >> + assert_bit_set(dir, DSKCHG); >> + dir = inb(FLOPPY_BASE + reg_dir); >> + assert_bit_set(dir, DSKCHG); >> + >> + /* Insert media for other tests. */ >> + qmp("{'execute':'change', 'arguments':{ 'device':'floppy0', " >> + "'target': '%s' }}", test_image); >> + qmp(""); /* ignore event (FIXME open -> open transition?!) */ >> + qmp(""); /* ignore event */ >> +} Can you also include a read from the CMOS to verify your fix? > This makes it impossible to use the testcase with -p/-s (try > tests/fdc-test --help). Please move these commands to > test_media_change. Makes sense. > Alternatively (perhaps better), leave the "-drive" > option and add a matching eject command to test_no_media_on_start. Ejecting a floppy while the VM is running is different from not having it inserted at startup. Not sure, maybe system_reset after ejecting would help to run the same code paths. Kevin